Re: Want to help upstream software improve their random?

2014-12-13 Thread martin
t upstream's views on random number generation can be mighty strange. Many are of the opinion that an insecure fallback is better than refusing to compile. Not that it is an excuse for poor software engineering, but many are old enough to be rather jumbled in their library use. I tried to CC their list but it won't let me post without subscribing and furthermore I couldn't seem to subscribe. -- Martin

lock and term in cwm menu

2014-12-15 Thread martin
Revision 1.178 of xenocara/app/cwm/conf.c made lock and term always show at top of application menu. I don't see a way to remove this. Will this be permanent behavior now? -- Martin

Flag to set from address in mail(1)

2015-01-03 Thread martin
because the code would be more complicated than necessary. But maybe somebody wants the compatibility? Thoughts? -- Martin Brandenburg Index: mail.1 === RCS file: /cvs/src/usr.bin/mail/mail.1,v retrieving revision 1.70 diff -u -p

Re: Flag to set from address in mail(1)

2015-01-04 Thread martin
Nathanael Rensen wrote: > On Sun, 04 Jan 2015 05:57:38 +0000, Martin Brandenburg wrote: > > Since the ability to pass arbitrary arguments to sendmail has been > > removed from mail(1), I have added a variable and flag to pass a from > > address to sendmail. > > > &

Re: Set of 14 potential bugs

2013-07-12 Thread martin
On Fri, Jul 12, 2013 at 08:24:30PM +0200, Maxime Villard wrote: > Hi, > as I did for NetBSD, here is a list of 14 potential bugs/errors > found by my code scanner in OpenBSD: > > http://M00nBSD.net/e5ab5f6e59d6a0feb7d1a518acc8233d.html > > I do not provide patches. > You are right about m

Sony UWA-BR100 device support patch with AR9280+AR7010 onboard

2021-06-16 Thread Martin
Hi tech, Please add Sony UWA-BR100 device ID with well known AR9280+AR7010 to source tree (confirmed working). Martin if_athn_usb.c.patch Description: Binary data usbdevs.h.patch Description: Binary data

USB3 stack with async. transfers support

2020-07-07 Thread Martin
Hi tech@, Not so long ago I've ported UHD driver to support Ettus USRP devices which uses libusb and asynchronous USB3 data transfers. Is USB3 async. data stack implemented or planned to have some devices like USRP working? Martin

Re: [patch] Fail execve on environment duplicates

2017-05-09 Thread martin
> On Tue, May 9, 2017 at 4:17 PM, Ted Unangst wrote: > > Matthew Martin wrote: > > I would suggest N^2 loops are automatically forgiveable, If there > is a limit on N, > which is a reasonable number for any supported environment, but total > potential > impact on

printcap(5) error

2017-05-13 Thread martin
s the same without the sd option as when it is set to /var/spool/output/lpd. Am I missing something? Martin

Fix SHA256Init.3

2019-12-04 Thread Martin
Hey! Somehow the SHA256Init(3) man page ended up being the Makefile. This patch restores the last one and changes the references in the SEE ALSO section accordingly (like SHA1Init(3)). Kind regards, Martin Index: SHA256Init.3

Fix cross references in {MD5,SHA1,RMD160}Init.3

2019-12-05 Thread Martin
Hey! Some cross references in the {MD5,SHA1,RMD160}Init(3) pages are misspelled. Best, Martin Index: MD5Init.3 === RCS file: /cvs/src/lib/libc/hash/MD5Init.3,v retrieving revision 1.1 diff -u -p -r1.1 MD5Init.3 --- MD5Init.3 30

[2/3] ssh/readconf.c: reorder keywords

2019-12-19 Thread Martin
Hey! Part 2: This moves always unsupported keywords in the appropriate section. Also move oSecurityProvider to match the order in the OpCodes enum. Best, Martin diff --git readconf.c readconf.c index eff2d5d1672..c2c3d55b656 100644 --- readconf.c +++ readconf.c @@ -183,6 +183,9 @@ static

[3/3] ssh/readconf.c: Remove deprecated/unsupported opcodes

2019-12-19 Thread Martin
Hey! Final part: Remove deprecated/always unsupported opcodes from the enum. This is already the case for the majority of the deprecated/always unsupported opcodes. Best, Martin diff --git readconf.c readconf.c index c2c3d55b656..cc845c6fc16 100644 --- readconf.c +++ readconf.c @@ -130,15

[1/3] ssh/readconf.c: Remove SSH1 options in example

2019-12-19 Thread Martin
Hey! This diff removes unsupported SSH1 options from the format example comment. Best, Martin P.S.: This is the first of 3 diffs, I did them with git this time I hope they are in the correct format. diff --git readconf.c readconf.c index 44464bed71e..eff2d5d1672 100644 --- readconf.c

Update disklabel(8) man page

2020-01-28 Thread Martin
Hi Attached a diff to bring the disklabel man page up to date. Information taken directly from editor.c line 95. Best, Martin Index: disklabel.8 === RCS file: /cvs/src/sbin/disklabel/disklabel.8,v retrieving revision 1.138 diff -u

Start point to learn OpenBSD programming

2020-03-16 Thread Martin
Hello list, The best way for beginner to start with OpenbBSD programming? Martin

[patch] Tweak libssl manpages

2020-03-29 Thread Martin
Hi there! It seems these are just a coded form for no return value, unless this is some libssl slang I am not aware of. Best, Martin Index: SSL_CTX_set_client_CA_list.3 === RCS file: /cvs/src/lib/libssl/man

[patch] sys/queue.h

2020-03-31 Thread Martin
that the XSIMPLEQ* macros are not documented in the queue.3 page. From what I gathered from the mailing list is, that these were added for in kernel use. Is there a specific reason for not mentioning them in queue.3? If no, would you be open to a diff? Best, Martin Index: queue.h

[patch] mandoc: Remove argument names from function prototypes

2020-04-02 Thread Martin
Hi there! I think these are superfluous. Best, Martin Index: cgi.c === RCS file: /cvs/src/usr.bin/mandoc/cgi.c,v retrieving revision 1.109 diff -u -p -r1.109 cgi.c --- cgi.c 10 Jan 2020 15:20:49 - 1.109 +++ cgi.c

Re: Proxy ARP and npppd (tun)

2016-12-09 Thread martin
> From owner-tech+M54722=martin=martinbrandenburg@openbsd.org Fri Dec 9 > 13:42:59 2016 > From: Erik Lax > Subject: Proxy ARP and npppd (tun) > To: tech@openbsd.org > Date: Fri, 9 Dec 2016 19:42:46 +0100 > > Hi, > > In previous OpenBSD versions (5.9 and

[PATCH] inet(4) man page

2019-10-29 Thread Martin
Hi Small improvment for the inet(4) manpage. This makes it consistent with inet6(4). Kind regards, Martin Index: inet.4 === RCS file: /cvs/src/share/man/man4/inet.4,v retrieving revision 1.19 diff -u -p -r1.19 inet.4 --- inet.4

[PATCH] Add new warning to useradd

2019-10-31 Thread Martin
me/test_user' doesn't exist, and -m was not specified user: Warning: group with name test_user already exists with gid 1002 Comments, thoughts, feedback? Kind regards, Martin Index: user.c === RCS file: /cvs/src/usr.sbin

Multicast macros and global list of addresses

2013-09-19 Thread Martin Pieuchot
Diff below change the macros used to iterate over the multicast records linked to an interface without using the global lists of addresses. These records are currently link to the first address descriptor, respectively v4 and v6, even if they are per-interface. So I changed the code to loop over

Re: fill /* TODO: 11A */ in bwi_rf_set_chan()

2013-09-19 Thread Martin Pieuchot
pport 11A phy. So I'm not sure it makes sense to port code from the b43 driver. Martin

Re: openbsd ioctl fix (in6.c)

2013-10-01 Thread Martin Pieuchot
On 30/09/13(Mon) 14:17, Loganaden Velvindron wrote: > On Mon, Sep 30, 2013 at 10:51:47PM +0200, Alexander Bluhm wrote: > > On Wed, Sep 18, 2013 at 12:01:10AM -0700, Loganaden Velvindron wrote: > > > Index: in6.c > > > === > > > RCS fil

Re: Multicast macros and global list of addresses

2013-10-01 Thread Martin Pieuchot
On 19/09/13(Thu) 13:59, Martin Pieuchot wrote: > Diff below change the macros used to iterate over the multicast > records linked to an interface without using the global lists of > addresses. > > These records are currently link to the first address descriptor, > respectively

Re: Multicast macros and global list of addresses

2013-10-02 Thread Martin Pieuchot
On 01/10/13(Tue) 19:53, Loganaden Velvindron wrote: > On Tue, Oct 1, 2013 at 3:33 PM, Martin Pieuchot > wrote: > > On 19/09/13(Thu) 13:59, Martin Pieuchot wrote: > >> Diff below change the macros used to iterate over the multicast > >> records linked to an inte

Re: Multicast macros and global list of addresses

2013-10-04 Thread Martin Pieuchot
On 02/10/13(Wed) 21:33, Stuart Henderson wrote: > On 2013/09/19 13:59, Martin Pieuchot wrote: > > Diff below change the macros used to iterate over the multicast > > records linked to an interface without using the global lists of > > addresses. > > > > These

Re: getifaddrs() netmasks with af=0 on vlan/lo

2013-10-04 Thread Martin Pieuchot
On 04/10/13(Fri) 11:46, Stuart Henderson wrote: > It seems that for some interface types (I noticed vlan and lo), a netmask > with af==0 is returned by getifaddrs(). > > Not sure if this was always broken or introduced more recently; happens > on at least 5.3 and -current so it's not anything part

Promiscuous mode and multicast

2013-10-04 Thread Martin Pieuchot
tl;dr This diff stop (ab)using the actual SIOC{ADD,DEL}MULTI ioctls with a magic value for the whole range of multicast addresses used for IPv4/6 to turn the interface into promiscuous mode. Long story Ethernet multicast records are currently represented by the ``struct ether_multi'' as ran

Re: Promiscuous mode and multicast

2013-10-07 Thread Martin Pieuchot
On 04/10/13(Fri) 21:52, Brad Smith wrote: > On Fri, Oct 04, 2013 at 03:18:45PM +0200, Martin Pieuchot wrote: > > tl;dr > > > > This diff stop (ab)using the actual SIOC{ADD,DEL}MULTI ioctls with a > > magic value for the whole range of multicast addresses used

Re: partial xlocale(3) port from FreeBSD

2013-10-15 Thread Martin Pelikan
> - port xlocale(3) from FreeBSD -- this is what this patch does > > I did the patch in two parts, separating include/ and lib/libc/, because my Second part (include/ headers) follows. -- Martin Pelikan Index: _ctype.h ==

Re: partial xlocale(3) port from FreeBSD

2013-10-15 Thread Martin Pelikan
> > - port xlocale(3) from FreeBSD -- this is what this patch does > > > Second part (include/ headers) follows. Apologies, I left one bit out. Here it is. -- Martin Pelikan Index: locale.h === RCS file: /cvs/src/i

Ethernet drivers and multicast filters

2013-10-17 Thread Martin Pieuchot
Diff below converts the remaining drivers in our tree that still compare the low and high value of their Ethernet multicast ranges to set the IFF_ALLMULTI flag to use "ac->ac_multirangecnt" instead. This should not change the behavior of any driver. The goal if this diff is to stop using the ``en

unlimited HFSC

2013-10-17 Thread Martin Pelikan
got a possible speedup as well! :-) Ok's? Comments? Can haz committed? -- Martin Pelikan Index: net/hfsc.c === RCS file: /cvs/src/sys/net/hfsc.c,v retrieving revision 1.1 diff -u -p -r1.1 hfsc.c --- net/hfsc.c 12 Oct 2013

Re: in6_leavegroup work queue

2013-10-18 Thread Martin Pieuchot
be here when the task will be scheduled, so passing a pointer might not be a good idea. That is why I wanted to change the if_get() API to use unique index for each interface... But maybe there's another solution at this problem than using a workq... Martin

unlimited HFSC v2: [part 1] rename pf_altq::altq_disc

2013-10-18 Thread Martin Pelikan
;altq_disc" as "transition.altq.altq_disc" will clash with pf_altq's member. This diff renames pf_altq::altq_disc to altq_disc_state. (Ah, the good old C namespace problems! ;-)) It builds on amd64 and shouldn't make any difference. ok? -- Mart

unlimited HFSC v2: [part 2]: the actual work

2013-10-19 Thread Martin Pelikan
s pointer field (which will be gone after transition). Compiles & is being tested on amd64. -- Martin Pelikan Index: altq/if_altq.h === RCS file: /cvs/src/sys/altq/if_altq.h,v retrieving revision 1.16 diff -u -p -r1.16 if_altq.h --

Re: Add Xbox 360 Controller USB support

2013-10-20 Thread Martin Pieuchot
Hi Jeremy, On 18/10/13(Fri) 09:11, Jeremy Evans wrote: > This was originally submitted by Joe Gidi in November 2010, based on a > FreeBSD commit by Ed Schouten from back in December 2005. See > http://marc.info/?l=openbsd-tech&m=128924886803756&w=2 for previous > thread. The only comment was fro

unlimited HFSC v3: more readable, less hacks

2013-10-20 Thread Martin Pelikan
e (it can remain 2 years old), removes the now useless ifq_hfsc pointer. As always, it's being heavily tested. -- Martin Pelikan ? net/hfsc.c.instrumented Index: altq/if_altq.h === RCS file: /cvs/src/sys/altq/if_altq.h,v

Re: partial xlocale(3) port from FreeBSD

2013-10-20 Thread Martin Pelikan
ing it xlocale or others), I suspect libcxx maintainers won't be very happy about #ifdef __OpenBSD__ Please correct me if the philosophy is wrong. Or better, suggest other ways forward :-) -- Martin Pelikan

Re: Add Xbox 360 Controller USB support

2013-10-21 Thread Martin Pieuchot
On 20/10/13(Sun) 12:09, Jeremy Evans wrote: > On 10/20 03:52, Martin Pieuchot wrote: > > [...] > > Thanks for responding. Here's a new diff that incorporates most of your > suggestions. Unfortunately, using the existing quirks infrastructure > doesn't work corre

Re: partial xlocale(3) port from FreeBSD

2013-10-21 Thread Martin Pelikan
add it to our ports tree. > > The shim is going to be a lot less work, and doesn't preclude an > implentation inside libc at a later stage. Thanks for showing the right direction. I'll look into it as soon as I have more time; at least I know what is needed and how big is it. -- Martin Pelikan

HFSC queue pusher

2013-10-27 Thread Martin Pelikan
tree, to make it work with unlimited v3 diff, you obviously need to substitute some ->'s for .'s. comments? ok? -- Martin Pelikan Index: hfsc.c === RCS file: /cvs/src/sys/net/hfsc.c,v retrieving revision 1.1 diff -u -p -

Re: HFSC queue pusher

2013-10-28 Thread Martin Pelikan
> As far as I know, HZ is all we have in a portable fashion. How do you > get better? > > (I have an answer. I've prodded for years. Noone has bit yet. Maybe > you will). Is the answer "start writing drivers for other timers and make them run softclock independently of the scheduler tick"? D

Re: Genesys Logic GL620USB-A, USB PC-to-PC link cable

2013-10-29 Thread Martin Pieuchot
ransfers and pipe? Just kill it ;) Other than that I'd say ok mpi@, but don't forget the man page and enable it where upl(4) is enable! Cheers, Martin

Re: in6_leavegroup work queue

2013-10-31 Thread Martin Pieuchot
On 30/10/13(Wed) 16:48, Alexander Bluhm wrote: > On Fri, Oct 18, 2013 at 01:00:25PM +0200, Martin Pieuchot wrote: > > On 18/10/13(Fri) 12:45, Alexander Bluhm wrote: > > > > > > Ethernet drivers connected via USB might sleep when their multicast > > > group fil

unlimited HFSC v4: against -current with deferred pushing

2013-10-31 Thread Martin Pelikan
Same as v3, only it applies to -current. ok? Index: altq/if_altq.h === RCS file: /cvs/src/sys/altq/if_altq.h,v retrieving revision 1.16 diff -u -p -r1.16 if_altq.h --- altq/if_altq.h 12 Oct 2013 12:13:10 - 1.16 +++ alt

pool(9) for usbd_xfer

2013-11-01 Thread Martin Pieuchot
Diff below converts the three USB controllers to use a pool(9) for allocating their transfer descriptors instead of maintaining their own custom free list. With it uhci(4) and ehci(4) no longer initialized the "isdone" value to 1 for every new transfer descriptor (if DIAGNOSTIC is defined). This i

Re: in6_leavegroup work queue

2013-11-05 Thread Martin Pieuchot
Alexander, I spent quite some time working on this problem and I found some interesting information, see below. On 31/10/13(Thu) 17:20, Alexander Bluhm wrote: > On Thu, Oct 31, 2013 at 09:56:11AM +0100, Martin Pieuchot wrote: > > On 30/10/13(Wed) 16:48, Alexander Bl

Re: help X11 performance: make sigprocmask(2) SY_NOLOCK

2013-11-08 Thread Martin Pieuchot
On 20/06/13(Thu) 15:18, Martin Pelikan wrote: > > And p_sigmask is copied during fork, so that needs a bit of thought. > > I guess it doesn't matter for the new child, as it isn't running yet > > and therefore can't invoke sigprocmask(2). And the parent should

Add fcu(4/macppc) to RAMDISK

2013-11-09 Thread Martin Pieuchot
Without this driver, it's impossible to upgrade my PowerMac7,3 without hearing a fan symphony. ok? Index: conf/RAMDISK === RCS file: /cvs/src/sys/arch/macppc/conf/RAMDISK,v retrieving revision 1.97 diff -u -p -r1.97 RAMDISK --- con

Ethernert drivers (MI) and muticast filters

2013-11-11 Thread Martin Pieuchot
I'm still looking for tests/oks for the driver changed in the diff below. Here's what I said on Oct 17th: > Diff below converts the remaining drivers in our tree that still compare > the low and high value of their Ethernet multicast ranges to set the > IFF_ALLMULTI flag to use "ac->ac_multirange

Ethernert drivers (MD) and muticast filters

2013-11-11 Thread Martin Pieuchot
Here's the other part of the diff, touching drivers in mvme68k, mvme88k sparc and vax. Index: arch/mvme68k/dev/if_ie.c === RCS file: /cvs/src/sys/arch/mvme68k/dev/if_ie.c,v retrieving revision 1.41 diff -u -p -r1.41 if_ie.c --- arch/m

Re: Genesys Logic GL620USB-A, USB PC-to-PC link cable (take 2)

2013-11-15 Thread Martin Pieuchot
On 14/11/13(Thu) 17:44, Brad Smith wrote: > On 14/11/13 3:29 PM, SASANO Takayoshi wrote: > >Hello, > > > >Here is Genesys Logic's GL620USB-A driver, new version. > >I fixed crashing bug when peer is not connected, rewrite "sc_dying" to > >usbd_is_dying() (advices from mpi@), and deleted useless cod

FDDI/ATM leftovers

2013-11-18 Thread Martin Pieuchot
Since we don't support any FDDI or ATM interfaces anymore, remove some special cases for such interface types in our kernel. ok? Index: arch//amd64/amd64/autoconf.c === RCS file: /home/ncvs/src/sys/arch/amd64/amd64/autoconf.c,v retri

Don't link multicast records to the first address

2013-11-18 Thread Martin Pieuchot
Diff below changes the way protocol multicast addresses are linked to an interface. Right now they are added to a list attached to the first protocol address of an interface. That makes this address descriptor and its position in the global list special. Plus in the IPv6 case, a special kludge

Re: convert sppp(4) to taskq

2013-11-18 Thread Martin Pieuchot
On 15/11/13(Fri) 15:45, Stefan Sperling wrote: > On Fri, Nov 15, 2013 at 03:20:48PM +0100, Mike Belopuhov wrote: > > On 15 November 2013 15:13, Stefan Sperling wrote: > > > Is this done right? > > > > > > Works here with pppoe(4) for both IPv4 and IPv6. > > > > > > > i think this diff might lack

Re: convert sppp(4) to taskq

2013-11-18 Thread Martin Pieuchot
On 18/11/13(Mon) 13:35, Stefan Sperling wrote: > On Mon, Nov 18, 2013 at 12:37:53PM +0100, Martin Pieuchot wrote: > > Even if right now calling task_del() is enough, do you know if there's > > an easy way to convert this code without putting the task storage in > &

Re: Ethernert drivers (MI) and muticast filters

2013-11-19 Thread Martin Pieuchot
On 11/11/13(Mon) 11:31, Martin Pieuchot wrote: > I'm still looking for tests/oks for the driver changed in the diff > below. > > Here's what I said on Oct 17th: > > > Diff below converts the remaining drivers in our tree that still compare > > the low and h

Re: Don't link multicast records to the first address

2013-11-19 Thread Martin Pieuchot
On 18/11/13(Mon) 12:54, Alexey E. Suslikov wrote: > Martin Pieuchot nolizard.org> writes: > > > -1803,8 +1651,12 in6_delmulti(struct in6_multi > *in6m) > > > > > + s = splsoftnet(); > > + TAILQ_REMOVE(&ifp

Re: hiding struct ifnet diff #4v2: _KERNEL

2013-11-19 Thread Martin Pieuchot
On 19/11/13(Tue) 15:25, Mike Belopuhov wrote: > Apparently, this leads to some funny results. There are a bunch of > prototypes under "ifndef _KERNEL": > > #ifndef _KERNEL > __BEGIN_DECLS > unsigned int if_nametoindex(const char *); > char*if_indextoname(unsigned int, char *); > struct if_na

Kill IA_SIN()

2013-11-20 Thread Martin Pieuchot
This one is not under _KERNEL but it's used at only one place and if a port use it, it should probably define it by itself. ok? Index: netinet/if_ether.c === RCS file: /home/ncvs/src/sys/netinet/if_ether.c,v retrieving revision 1.111

Unused proc argument in in6_control()

2013-11-20 Thread Martin Pieuchot
Any reason to keep this unused proc argument, in_control() does not have it. Ok to kill it? Index: netinet/tcp_usrreq.c === RCS file: /home/ncvs/src/sys/netinet/tcp_usrreq.c,v retrieving revision 1.116 diff -u -p -r1.116 tcp_usrreq.c

Re: Kill IA_SIN()

2013-11-20 Thread Martin Pieuchot
On 20/11/13(Wed) 10:16, Stuart Henderson wrote: > On 2013/11/20 10:10, Martin Pieuchot wrote: > > This one is not under _KERNEL but it's used at only one place and > > if a port use it, it should probably define it by itself. > > This is used in at least kde-workspace an

Re: Don't link multicast records to the first address

2013-11-22 Thread Martin Pieuchot
On 18/11/13(Mon) 11:43, Martin Pieuchot wrote: > Diff below changes the way protocol multicast addresses are linked to > an interface. > > Right now they are added to a list attached to the first protocol > address of an interface. That makes this address descriptor and > i

Kill IF_LEN() and IF_IS_EMPTY()

2013-11-22 Thread Martin Pieuchot
One kill a day, keeps... So, here's a diff that replaces these two macros by their IFQ_* equivalent and kill them. No object change. ok? Index: dev/ic/ar5008.c === RCS file: /home/ncvs/src/sys/dev/ic/ar5008.c,v retrieving revision

Re: uhub2: device problem, disabling port 2

2013-11-25 Thread Martin Pieuchot
On 22/11/13(Fri) 13:48, Stuart Henderson wrote: > uhub2: port 2, set config at addr 3 failed > uhub2: device problem, disabling port 2 > > When this happens, is there any way to get the port back without rebooting? Have you tried suspending/resuming the machine? Apart from that, the diff below i

rdomain -> rtableid confusion

2013-11-26 Thread Martin Pieuchot
These two functions take a rtableid not a rdomain as an argument, simple renaming to avoid confusion. ok? Index: net/if.c === RCS file: /home/ncvs/src/sys/net/if.c,v retrieving revision 1.277 diff -u -p -r1.277 if.c --- net/if.c1

No need for INADDR_TO_IFP(), less global IPv4 list usage

2013-11-26 Thread Martin Pieuchot
Diff below replaces the INADDR_TO_IFP() macro that iterates over the global list of IPv4 by a call to in_iawithaddr() that uses the global tree of addresses. Since these two structures are now always coherent it is safe to replace one by the other and this removes one more usage of the global list

Re: Don't link multicast records to the first address

2013-11-27 Thread Martin Pieuchot
On 22/11/13(Fri) 08:42, Stuart Henderson wrote: > I tried the old version (I'm using igmpproxy on my firewall and have native > multicast over pppoe), no problems, but I haven't carefully read the diff yet. Thanks, I also got positive feedbacks from weerd@ who tested IPv6 Neighbor Discovery, so i

Use per-interface list in IFP_TO_IA()

2014-01-07 Thread Martin Pieuchot
oks. Martin Index: netinet/in_var.h === RCS file: /home/ncvs/src/sys/netinet/in_var.h,v retrieving revision 1.31 diff -u -p -r1.31 in_var.h --- netinet/in_var.h29 Nov 2013 00:19:33 - 1.31 +++ netinet/in_var.h7 Jan

rti_info and defines

2014-01-08 Thread Martin Pieuchot
I find it really difficult to understand and work with the code of rtsock.c because of the following defines: /* Sleazy use of local variables throughout file, warning */ #define dstinfo.rti_info[RTAX_DST] #define gate info.rti_info[RTAX_GATEWAY] ... But

Useless lookup in ether_input()

2014-01-14 Thread Martin Pieuchot
Diff below replaces a lookup to find the link-layer address by accessing the if_sadl member directly. ok? Index: net/if_ethersubr.c === RCS file: /home/ncvs/src/sys/net/if_ethersubr.c,v retrieving revision 1.159 diff -u -p -r1.159 if_

Re: Introduce rt_msg() (was nd6_rtmsg)

2014-01-14 Thread Martin Pieuchot
On 02/09/13(Mon) 07:54, Kenneth R Westerback wrote: > On Mon, Sep 02, 2013 at 12:43:51PM +0200, Martin Pieuchot wrote: > > Diff below is just a small refactoring of two similar code chunks to > > inform user processes that something changed regarding a route. > > > &

Cleanup rtsock crazy defines

2014-01-20 Thread Martin Pieuchot
Here's a diff that substitutes the crazy defines of rtsock.c plus some 0 -> NULL conversion. There's no object change with it. ok? Index: net/rtsock.c === RCS file: /home/ncvs/src/sys/net/rtsock.c,v retrieving revision 1.134 diff -u

Re: More radix.c cleanup

2014-01-21 Thread Martin Pieuchot
On 21/01/14(Tue) 05:05, Claudio Jeker wrote: > Cleanup the abuse of x as the rn_addmask radix node. Since in most > cases x is just used as a temp variable. Main offender is rn_addmask() > which sets x once at the top uses it then late in the function and then > starts reuing it for various other s

RTF_HOST and netmask

2014-01-22 Thread Martin Pieuchot
Diff below kills the unused RTAX_NETMASK arguments and the global variable associated of two requests where a route to host is added or deleted. ok? Index: netinet6/in6.c === RCS file: /home/ncvs/src/sys/netinet6/in6.c,v retrieving r

if_detach() addresses cleanup

2014-01-22 Thread Martin Pieuchot
Network addresses added to the interface local list thought ifa_add() are the link-local address and the IPv4/6 ones. Since if_detach() now calls in_ifdetach(), there should be no address left on the list apart from the link-layer one at this stage. So the diff below removes it directly, there's

rtinit, RTF_HOST and netmask

2014-02-04 Thread Martin Pieuchot
Diff below removes an old comment about bsdi4 and make it clear that netmasks are not needed for routes to host. ok? Index: net/route.c === RCS file: /home/ncvs/src/sys/net/route.c,v retrieving revision 1.151 diff -u -p -r1.151 route

Re: ip6opt.c

2014-02-07 Thread Martin Pieuchot
On 06/02/14(Thu) 19:43, Eitan Adler wrote: > On Tue, Feb 4, 2014 at 8:54 PM, Alexander Bluhm > wrote: > > On Tue, Feb 04, 2014 at 08:35:02PM -0500, Eitan Adler wrote: > >> Hi all, > >> > >> The following bug was recently fixed in DragonFlyBSD and FreeBSD: > >> > >> libc/net: Fix issue in inet6_op

carp sends incorrect NA

2014-02-11 Thread Martin Pieuchot
When a carp node sends a neighbor advertisement, because its status switch from BACKUP to MASTER for example, it does it using a wrong mac address: the one from its real associated interface (carpdev). Because of this, a hack was added later on to remove and re-add the route entry to loopback for

Re: rtinit, RTF_HOST and netmask

2014-02-11 Thread Martin Pieuchot
On 04/02/14(Tue) 10:50, Martin Pieuchot wrote: > Diff below removes an old comment about bsdi4 and make it clear that > netmasks are not needed for routes to host. > > ok? Anybody? > > Index: net/route.c >

Re: carp sends incorrect NA

2014-02-12 Thread Martin Pieuchot
On 11/02/14(Tue) 19:40, Alexander Bluhm wrote: > On Tue, Feb 11, 2014 at 03:53:24PM +0100, Martin Pieuchot wrote: > > When a carp node sends a neighbor advertisement, because its status > > switch from BACKUP to MASTER for example, it does it using a wrong > > mac address:

carp BACKUP and NA

2014-02-19 Thread Martin Pieuchot
Generally, when a NA is received we check if the receiving interface has the target address advertised and if it's the case we warn about duplicate addresses and bail. But in the case of a carp interface in BACKUP state it's different. In this case we have a hack that sets the ifa to NULL and con

Re: upd(4) proposal

2014-02-20 Thread Martin Pieuchot
On 17/02/14(Mon) 01:11, Andre de Oliveira wrote: > On Fri, Feb 14, 2014 at 02:20:57PM +0100, Ingo Schwarze wrote: > > Hi, > > > > a few comments regarding the manual: > > Ingo, thanks for your feedback. > Here follows an updated version, just documentation changes. > > I also submitted it to man

Re: upd(4) proposal

2014-02-20 Thread Martin Pieuchot
On 20/02/14(Thu) 14:32, Reyk Floeter wrote: > On 20.02.2014, at 12:23, Martin Pieuchot wrote: > >> [...] > >> + /* > >> + * init usbdata > >> + * those commands width were identified from observing apcupsd/ugen(4) > >> + * data ex

Re: carp BACKUP and NA

2014-03-06 Thread Martin Pieuchot
On 19/02/14(Wed) 12:53, Martin Pieuchot wrote: > Generally, when a NA is received we check if the receiving interface > has the target address advertised and if it's the case we warn about > duplicate addresses and bail. > > But in the case of a carp interface in BACKUP state

Re: if_detach() addresses cleanup

2014-03-06 Thread Martin Pieuchot
On 22/01/14(Wed) 11:46, Martin Pieuchot wrote: > Network addresses added to the interface local list thought ifa_add() > are the link-local address and the IPv4/6 ones. > > Since if_detach() now calls in_ifdetach(), there should be no address > left on the list apart from the li

Re: carp BACKUP and NA

2014-03-06 Thread Martin Pieuchot
On 06/03/14(Thu) 09:34, Martin Pieuchot wrote: > On 19/02/14(Wed) 12:53, Martin Pieuchot wrote: > > Generally, when a NA is received we check if the receiving interface > > has the target address advertised and if it's the case we warn about > > duplicate addresses and

M_ZERO usbd pipes

2014-03-07 Thread Martin Pieuchot
Since usbd pipes contain a per-controller part, I'd like to malloc them with M_ZERO to properly initialize the per-controller fields to 0. ok? Index: usb_subr.c === RCS file: /cvs/src/sys/dev/usb/usb_subr.c,v retrieving revision 1.98

unify *hci timeout & abort task hook

2014-03-07 Thread Martin Pieuchot
Diff below unify the various *hci_timeout() functions, there should be no functional change. Since this code is identical in all our drivers, the next step will be to provide a new hook to not reroll it in the two upcoming HC drivers. ok? Index: ehci.c ===

Split IPv4 automagic route to prefix/host creation

2014-03-10 Thread Martin Pieuchot
Diff below splits in_addprefix() into two functions, one for adding a route to host (for point-to-point interfaces) and one for adding a route prefix. This simplifies a lot the RTF_* flags logic and will make it easier to create routes to loopback in a near future. The only difference it introduc

RTAX_IFP, wait, what is that?

2014-03-10 Thread Martin Pieuchot
Diff below makes it clear that RTAX_IFP points to the interface's sockaddr_dl, which is always the first element of the per-ifp list of address. Just use the pointer present in "struct ifnet" instead of relying on the fact that the link-layer address is the first element of the list. ok? Index:

Stop abusing rcvif pointer to pass wireless nodes

2014-03-14 Thread Martin Pieuchot
Diff below adds a new pointer to "struct pkthdr" to explicitly pass some wireless nodes to the pointer without abusing the interface pointer that I'd like to kill. I kept and updated the comments saying that this way of passing the corresponding node is a hack since using a dedicated pointer does

Claim all reportIDs of one uhidev(4) device

2014-03-16 Thread Martin Pieuchot
Diff below adds a hack to uhidev(4) to be able to have a subdriver claim *all* the reportIDs of a device. I'd like to commit it to be able to put upd(4) in tree soon in this release cycle and to allow me to progressively convert every driver. I did consider the idea of having a way to let a drive

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-17 Thread Martin Pieuchot
On 14/03/14(Fri) 15:46, Martin Pieuchot wrote: > Diff below adds a new pointer to "struct pkthdr" to explicitly pass > some wireless nodes to the pointer without abusing the interface > pointer that I'd like to kill. > > I kept and updated the comments sayin

Re: Split IPv4 automagic route to prefix/host creation

2014-03-17 Thread Martin Pieuchot
On 10/03/14(Mon) 15:28, Martin Pieuchot wrote: > Diff below splits in_addprefix() into two functions, one for adding a > route to host (for point-to-point interfaces) and one for adding a > route prefix. > > This simplifies a lot the RTF_* flags logic and will make it easier > t

Re: if_detach() addresses cleanup

2014-03-17 Thread Martin Pieuchot
On 06/03/14(Thu) 09:35, Martin Pieuchot wrote: > On 22/01/14(Wed) 11:46, Martin Pieuchot wrote: > > Network addresses added to the interface local list thought ifa_add() > > are the link-local address and the IPv4/6 ones. > > > > Since if_detach() now calls in_ifd

Re: Stop abusing rcvif pointer to pass wireless nodes

2014-03-18 Thread Martin Pieuchot
On 18/03/14(Tue) 11:26, Mike Belopuhov wrote: > On 18 March 2014 07:20, Claudio Jeker wrote: > > On Mon, Mar 17, 2014 at 11:41:38AM -0600, Theo de Raadt wrote: > >> > What about using a more generic name which is not bound to 80211 since > >> > the > >> > field is a generic pointer. This may allo

  1   2   3   4   5   6   7   8   9   10   >