Re: [patch] ssh: null pointer dereference

Hello, On Sat, Apr 10, 2010 at 03:49:07PM +1000, Damien Miller wrote: > Applied - thanks. This case shouldn't happen, if you are able to hit > this code then please tell me how you do it :| I haven't hit this code, it was just something suspicious that I found. I've been looking for bugs to fix a

Re: [patch] libc: wordexp support

Hello, On Tue, Apr 06, 2010 at 02:34:03PM -0600, Theo de Raadt wrote: > > On Tue, Apr 06, 2010 at 11:55:21AM -0400, Ted Unangst wrote: > > I'm sorry, but this is terrible. (Not your effort, which is > > appreciated, but the whole function.) I do not like the idea of > > adding a "be extra carefu

[patch] openssl: pr/6282

Hello, The openssl command line tool treats the non-null terminated buffer "mbuf" as a C string when using the pop3 s_client feature. This causes a segmentation fault with malloc.conf option "J" set when BIO_printf() runs off the end of the buffer. The following patch fixes PR 6282. Matthew Inde

Re: [patch] less: filename globbing/expansion

Hello, On Fri, Apr 02, 2010 at 07:08:43PM -0700, Philip Guenther wrote: > are we still tracking the upstream less(1) and if so, is the > behavioral change acceptable there? On Sat, Apr 03, 2010 at 03:37:46PM +1030, Matthew Haub wrote: > We no longer track upstream less(1). The last s

[patch] libc: wordexp support

Hello, This patch adds support for wordexp(3) and wordfree(3) to libc. These functions conform to IEEE Std 1003.1-2001 (POSIX). The implementation comes from NetBSD and uses a shell builtin, "wordexp", to perform the expansion in line with the methods suggested in the specification[1]. Matthew [

Re: [patch] ksh: autocomplete special characters

Hello, On Sat, Apr 03, 2010 at 11:33:56PM -0700, patrick keshishian wrote: > Above switch statement doesn't conform with style(9). Also > it is missing "break;". Here is the updated patch conforming to style(9). Thank you, Matthew Index: edit.c ==

Re: [patch] ksh: autocomplete special characters

Hello, On Sun, Apr 04, 2010 at 11:41:56AM +0930, Matthew Haub wrote: > The following patch fixes ksh autocomplete support for files within > directories containing []:`$= characters. This also fixes the problem > ray@ was experiencing with the back quotes in PR user/6006. Here's

[patch] ksh: autocomplete special characters

Hello, The following patch fixes ksh autocomplete support for files within directories containing []:`$= characters. This also fixes the problem ray@ was experiencing with the back quotes in PR user/6006. Matthew Index: edit.c === R

Re: [patch] less: filename globbing/expansion

Hello, On Fri, Apr 02, 2010 at 07:08:43PM -0700, Philip Guenther wrote: > if you want this, you should just implement wordexp(3) in libc and > then use that. I'll look into it, thank you. > are we still tracking the upstream less(1) and if so, is the > behavioral change acceptable there? We no

[patch] less: filename globbing/expansion

Hello, less(1) fails to write its buffer to pathnames with environment variables or the tilda home directory shortcut in them. The following patch corrects this by using the shell to glob filenames with lessecho instead of glob(3). Reproduction instructions: $ echo hi | less hi [type "s~/newfile.

[patch] ssh: null pointer dereference

Hello, If channel_by_id() in mux_master_control_cleanup_cb() fails to find the session channel then pointer "sc" will be NULL when dereferenced. Index: usr.bin/ssh/mux.c === RCS file: /cvs/src/usr.bin/ssh/mux.c,v retrieving revision