Re: timer(4/sparc64): remove driver

2023-03-18 Thread Ted Bullock
On 2023-03-17 12:29 p.m., Mike Larkin wrote: > On Thu, Mar 16, 2023 at 12:25:15PM -0500, Scott Cheloha wrote: >> This code has been dead since we switched sparc64 to clockintr several >> months ago. Nobody has come forward asking for a timer(4/sparc64) >> intrclock. >> >> As of now, you need %TICK

Internal libevent functions that should be private

2023-02-06 Thread Ted Bullock
Pretty sure these functions shouldn't be exported in the shared library: event_err event_warn event_errx event_warnx event_msgx _event_debugx I think this is correct usage of __BEGIN_HIDDEN_DECLS? diff /usr/src commit - c91a0f502346babf19c59a6b6d974a94c32ea1b1 path + /usr/src blob - 2f3509409475

libevent manuals

2023-01-16 Thread Ted Bullock
over time. I'm planning to finish off documenting the rest of the library, if folks have feedback, I'm interested. Take Care, event_init.3 .\" Copyright (c) 2023 Ted Bullock .\" .\" Permission to use, copy, modify, and distribute this software for any .\"

Re: sparc64: normalize prom mappings

2023-01-07 Thread Ted Bullock
On 2023-01-05 12:59 p.m., Miod Vallat wrote: > tl;dr: if you have a sparc64 machine, please try this diff and report if >your system no longer works with it. Tried it on a sunblade 100; machine still boots. -- Ted Bullock

Potential NULL dereference id_entry

2022-04-30 Thread Ted Bullock
= NULL); + rdev->flags = id_entry->driver_data; rdev->family = rdev->flags & RADEON_FAMILY_MASK; rdev->pc = pa->pa_pc; -- Ted Bullock

remove duplicate fbnode declaration for sparc64

2022-04-30 Thread Ted Bullock
addr, mask; int s; -#if defined(__sparc64__) || defined(__macppc__) +#if defined(__macppc__) extern int fbnode; #endif -- Ted Bullock

Re: Multiple issues with radeondrm startup code

2022-02-13 Thread Ted Bullock
On 2022-02-14 12:50 a.m., Jonathan Gray wrote: On Mon, Feb 14, 2022 at 12:05:44AM -0700, Ted Bullock wrote: On 2022-02-13 11:02 p.m., Jonathan Gray wrote: On Sun, Feb 13, 2022 at 12:22:38PM -0700, Ted Bullock wrote: On 2022-02-12 6:46 p.m., Jonathan Gray wrote: I will review further when

Re: Multiple issues with radeondrm startup code

2022-02-13 Thread Ted Bullock
On 2022-02-13 11:02 p.m., Jonathan Gray wrote: On Sun, Feb 13, 2022 at 12:22:38PM -0700, Ted Bullock wrote: On 2022-02-12 6:46 p.m., Jonathan Gray wrote: I will review further when you drop the function. Alright try this again, I have committed some parts of this, with one commit per

Re: Multiple issues with radeondrm startup code

2022-02-13 Thread Ted Bullock
pci_conf_write(pa->pa_pc, pa->pa_tag, PCI_ROM_REG, base); } -#endif #ifdef notyet mtx_init(&rdev->swi_lock, IPL_TTY); @@ -665,6 +703,11 @@ radeondrm_attach_kms(struct device *parent, struct dev dev = drm_attach_pci(&kms_driver, pa, is_agp, rdev->primary, self, NULL); + if (dev == NULL) { + printf("%s: drm_attach_pci failed\n", rdev->self.dv_xname); + radeon_fatal_error = 1; + return; + } rdev->ddev = dev; rdev->pdev = dev->pdev; -- Ted Bullock

Re: Multiple issues with radeondrm startup code

2022-02-12 Thread Ted Bullock
On 2022-02-11 7:16 p.m., Jonathan Gray wrote: > On Fri, Feb 11, 2022 at 06:42:11PM -0700, Ted Bullock wrote: >> >> There is more to this function that I think is problematic, >> especially from a MI point of view but I thought I would leave it >> off here. Below is

Multiple issues with radeondrm startup code

2022-02-11 Thread Ted Bullock
mio_bar, type, BUS_SPACE_MAP_LINEAR, NULL, - &rdev->rmmio_bsh, &rdev->rmmio_base, &rdev->rmmio_size, 0)) { - printf(": can't map rmmio space\n"); - return; - } - rdev->rmmio = bus_space_vaddr(rdev->memt, rdev->rmmio_bsh); - -#if !defined(__sparc64__) /* * Make sure we have a base address for the ROM such that we * can map it later. @@ -633,7 +686,6 @@ radeondrm_attach_kms(struct device *parent, struct dev size, 0, 0, 0, &base) == 0) pci_conf_write(pa->pa_pc, pa->pa_tag, PCI_ROM_REG, base); } -#endif #ifdef notyet mtx_init(&rdev->swi_lock, IPL_TTY); @@ -665,6 +717,11 @@ radeondrm_attach_kms(struct device *parent, struct dev dev = drm_attach_pci(&kms_driver, pa, is_agp, rdev->primary, self, NULL); + if(dev == NULL) { + printf("%s: drm_attach_pci failed\n", rdev->self.dv_xname); + radeon_fatal_error = 1; + return; + } rdev->ddev = dev; rdev->pdev = dev->pdev; -- Ted Bullock

Re: kubsan tcp timer shift

2022-01-21 Thread Ted Bullock
r from being mysterious with implicit data types? I've never seen a compelling reason to use defines when const variables get a degree of type protection and misuse gets caught by the compiler much more quickly. -- Ted Bullock

Re: Proposal for changes to the event(3) documentation

2014-05-19 Thread Ted Bullock
On Mon, May 19, 2014 at 8:39 AM, Nicholas Marriott wrote: > What approach are you (Ted) going to take here? I still want to see event(3) continue to be a general overview of how to use the library, even with some example code > I don't fancy doing loads of relatively small commits to event(3).

Re: Proposal for changes to the event(3) documentation

2014-05-17 Thread Ted Bullock
On Sat, May 17, 2014 at 12:08 PM, Ted Bullock wrote: > On Sat, May 17, 2014 at 3:33 AM, Jason McIntyre wrote: >> On Sat, May 17, 2014 at 03:09:03AM -0600, Ted Bullock wrote: >>> On Fri, May 16, 2014 at 1:10 AM, Nicholas Marriott >>> wrote: >>> > Hi >>