Re: [PATCH] Callback-based interface to libtls

Hey, the typedef came in handy :) Ok bcook@ > On Sep 5, 2016, at 11:52 AM, Bob Beck wrote: > > I am in agreement in principle, but please coordinate with bcook@ and/or > jsing@ who were possibly doing > some related adjustments. > > > >> On Mon, Sep 5, 2016 at 4:44 AM, Ted Unangst wrote: >

Re: ntpd: strptime portability problem

Ok bcook@ > On Mar 4, 2016, at 4:32 PM, Christian Weisgerber wrote: > > Matthias Andree noticed that the constraint > offset was always off by 3600 seconds for him (running OpenNTPD on > FreeBSD with CET timezone). > > The way we parse the HTTP date in the ntpd constraint code isn't > portable

[PATCH 1/2] use correct size_t formatter, include string.h for memcmp

From: Brent Cook --- base64/base64test.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/base64/base64test.c b/base64/base64test.c index a7d167e..fedbdcd 100644 --- a/base64/base64test.c +++ b/base64/base64test.c @@ -19,6 +19,7 @@ #include #include +#include #d

[PATCH 0/2] build warning fixes for regress/libcrypto

Hi all, Here are some minor build fixes for the libcrypto regression tests. - Brent

[PATCH 2/2] include openssl/evp.h for OPENSSL_add_all_algorithms_noconf()

From: Brent Cook --- rc4/rc4test.c | 1 + 1 file changed, 1 insertion(+) diff --git a/rc4/rc4test.c b/rc4/rc4test.c index a0b08a6..c4d34b1 100644 --- a/rc4/rc4test.c +++ b/rc4/rc4test.c @@ -60,6 +60,7 @@ #include #include +#include #include #include -- 1.9.2

[PATCH 5/6] do not pretend to support -rand in apps

From: Brent Cook Remove support for parsing the unused -rand option and the unused random buffer variables. --- src/apps/cms.c | 9 - src/apps/dgst.c | 8 ++-- src/apps/dhparam.c | 10 +- src/apps/dsaparam.c | 7 +-- src/apps/ecparam.c | 9 + src/ap

[PATCH 4/6] do not include public headers as though they are local

From: Brent Cook Avoid having to use -I trickery to find public header files included as though they are private. --- src/crypto/bn/bn_const.c | 2 +- src/crypto/chacha/chacha.c | 2 +- src/crypto/o_init.c | 2 +- src/crypto/pqueue/pqueue.c | 2 +- src/crypto/ts/ts_lib.c |

[PATCH 3/6] remove unused static datastructures

From: Brent Cook Neither of these is used anywhere within their object files. --- src/crypto/ec/ec_lib.c | 3 --- src/crypto/engine/eng_dyn.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/src/crypto/ec/ec_lib.c b/src/crypto/ec/ec_lib.c index b37efac..37dfd17 100644 --- a/src/crypto

[PATCH 6/6] use BIO_write instead of an unchecked write()

From: Brent Cook write() warns if its return value is unchecked. Replace with a BIO_write like all of the surrounding code uses anyway. --- src/apps/s_server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/apps/s_server.c b/src/apps/s_server.c index 4e1..729c94d 100

[PATCH 0/6] libssl compiler warning fixes

Hi all, This is a set of generic fixes to libssl/crypto that I found building with GCC 4.8 and Clang from LLVM 5.1. The first patch seems to be an actual bug, while the others are a little more pedantic (removing unused variables, fixing signed/unsigned char * aliases). - Brent

[PATCH 2/6] fix type string conversion warning

From: Brent Cook ASN1_STRING_data returns an unsigned char *, but strlcat's second parameter is a const char * --- src/crypto/ts/ts_rsp_verify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/crypto/ts/ts_rsp_verify.c b/src/crypto/ts/ts_rsp_verify.c index 2a4c0c5..49754b

[PATCH 1/6] initialize variable that can be used uninitialized

From: Brent Cook If EVP_DecryptInit_ex() returns NULL, j is incremented by a random amount. clang warning: pem/pem_lib.c:472:6: error: variable 'i' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (o) ^ pem/pem_lib.c:479:7: