Re: /usr/src/usr.sbin/lpr/common_source/rmjob.c diff

2016-01-26 Thread Theo Buehler
On Wed, Jan 27, 2016 at 12:39:04AM +0100, Ingo Schwarze wrote: > Theo Buehler wrote on Wed, Jan 27, 2016 at 12:04:43AM +0100: > > Todd Millert wrote: > > >> Please don't, alarm(3) is perfectly fine to be using. We should > >> probably remove that line from the manual. > > > The comment of alarm

Re: /usr/src/usr.sbin/lpr/common_source/rmjob.c diff

2016-01-26 Thread Todd C. Miller
On Wed, 27 Jan 2016 00:39:04 +0100, Ingo Schwarze wrote: > I would prefer the following patch. > > * Use the same wording up front as for ualarm(3). >It is relevant because alarm(3) and setitimer(ITIMER_REAL, ...) >cancel each other. Without that sentence, people might be misled >to

Re: /usr/src/usr.sbin/lpr/common_source/rmjob.c diff

2016-01-26 Thread Ingo Schwarze
Hi Theo, Theo Buehler wrote on Wed, Jan 27, 2016 at 12:04:43AM +0100: > Todd Millert wrote: >> Please don't, alarm(3) is perfectly fine to be using. We should >> probably remove that line from the manual. > The comment of alarm being made obsolete by setitimer has been there > for 30 years: >

Re: /usr/src/usr.sbin/lpr/common_source/rmjob.c diff

2016-01-26 Thread Theo Buehler
> Please don't, alarm(3) is perfectly fine to be using. We should > probably remove that line from the manual. The comment of alarm being made obsolete by setitimer has been there for 30 years: https://www.freebsd.org/cgi/man.cgi?query=alarm&apropos=0&sektion=0&manpath=2.10+BSD&arch=default&form

Re: /usr/src/usr.sbin/lpr/common_source/rmjob.c diff

2016-01-26 Thread Todd C. Miller
On Tue, 26 Jan 2016 12:52:54 -0600, Chris Bennett wrote: > I actually started to think I was wrong after I posted diff. Was reading > man pages about signals just now. I didn't know there was an alarm man > page, thanks. It looks like I need to rewrite code to use setitimer > since alarm is now ob

Re: /usr/src/usr.sbin/lpr/common_source/rmjob.c diff

2016-01-26 Thread Chris Bennett
On Tue, Jan 26, 2016 at 07:24:05PM +0100, Theo Buehler wrote: > On Tue, Jan 26, 2016 at 11:40:44AM -0600, Chris Bennett wrote: > > I found this in several other files in lpr src directories. > > Doesn't seem to get used in any lp* files or connect with anything > > higher up. > > > > Am I looking

/usr/src/usr.sbin/lpr/common_source/rmjob.c diff

2016-01-26 Thread Chris Bennett
I found this in several other files in lpr src directories. Doesn't seem to get used in any lp* files or connect with anything higher up. Am I looking at this correctly or way off? Thanks, Chris Index: rmjob.c === RCS file: /cvs/src