Re: [PATCH] Fix for kernel crash with udav(4) device

2011-03-21 Thread Matthias Kilian
On Sun, Mar 20, 2011 at 04:07:33PM -0400, Loganaden Velvindron wrote: With input from mk, we improved the diff. Testing is very much appreciated. [...] I can't comment on the code (it isn't my area, but, worse, i'm still too short of time), but at least a make build over nfs now finished

Re: [PATCH] Fix for kernel crash with udav(4) device

2011-03-20 Thread Loganaden Velvindron
With input from mk, we improved the diff. Testing is very much appreciated. mk@ suggests checking total_len right after xfer_status to make sure the header is safe to use. There's a mistake in the DPRINTF() fo RX status, one parameter is missing. This caused another crash when debug mode is

Re: [PATCH] Fix for kernel crash with udav(4) device

2011-03-17 Thread Loganaden Velvindron
Ok, I tested it with an NFS server, and also tested it with SFTP. The original diff works fine with the original diff. udav(4) uses 1514 bytes for largest values of total_len. //Logan C-x-C-c

[PATCH] Fix for kernel crash with udav(4) device

2011-03-14 Thread Loganaden Velvindron
This device: udav0 at uhub5 port 2 ShanTou DM9601 rev 1.10/1.01 addr 2 udav0: address 00:60:6e:00:6e:20 amphy0 at udav0 phy 0: DM9601 10/100 PHY, rev. 0 causes a kernel crash with the following messages: memcpy() at memcpy+0x16 usb_transfer_complete() at usb_transfer_complete+0x256