Re: [PATCH] update zlib to 1.2.8

2014-12-24 Thread Timo Myyrä
Marc Espie writes: > Updating zlib correctly is surprisingly difficult. > > It's not just a question of whipping out the new version and doing a diff. > You should make tests. > > Like, you missed the #ifdef SMALL at first. Those tests include making a > full release, and making sure it still wor

Re: [PATCH] update zlib to 1.2.8

2014-12-24 Thread Timo Myyrä
Stuart Henderson writes: > On 2014/12/23 22:54, Timo Myyrä wrote: >> I was trying to port notmuch mail indexer but got little stuck with it as it >> requires newer Zlib version than whats in base. I got little spare time in >> my >> hands and here's a rough patch which updates the base libz 1.2

Re: [PATCH] update zlib to 1.2.8

2014-12-24 Thread Marc Espie
Updating zlib correctly is surprisingly difficult. It's not just a question of whipping out the new version and doing a diff. You should make tests. Like, you missed the #ifdef SMALL at first. Those tests include making a full release, and making sure it still works. It's also likely some of tho

Re: [PATCH] update zlib to 1.2.8

2014-12-24 Thread Stuart Henderson
On 2014/12/23 22:54, Timo Myyrä wrote: > I was trying to port notmuch mail indexer but got little stuck with it as it > requires newer Zlib version than whats in base. I got little spare time in my > hands and here's a rough patch which updates the base libz 1.2.3 to version > 1.2.8. So > far I'

Re: [PATCH] update zlib to 1.2.8

2014-12-23 Thread Jonas 'Sortie' Termansen
Hi, There's some value in having a newer zlib release. There have been bugfixes, documentation fixes, various improvements, and API additions. I'm not sure how much is backported to the OpenBSD zlib, but a quick glance through your attached patch suggests there's stuff that would be nice to hav

Re: [PATCH] update zlib to 1.2.8

2014-12-23 Thread Joerg Sonnenberger
On Tue, Dec 23, 2014 at 10:54:15PM +0200, Timo Myyrä wrote: > I was trying to port notmuch mail indexer but got little stuck with it as it > requires newer Zlib version than whats in base. It is easy to patch notmuch, the requirement is rather silly. FYI. Joerg