Re: [Patch] use exit() directly in usage()

2014-10-01 Thread Otto Moerbeek
On Wed, Oct 01, 2014 at 05:41:11PM -0500, Kent R. Spillner wrote: > ok kspillner@. It would be nice to replace some of those exit(1) with > exit(EXIT_FAILURE), but that should be a separate diff that also updates the > err/errx's as well. In general EXIT_XXX is frowned upon in OpenBSD.

Re: [Patch] use exit() directly in usage()

2014-10-01 Thread Kent R. Spillner
ok kspillner@. It would be nice to replace some of those exit(1) with exit(EXIT_FAILURE), but that should be a separate diff that also updates the err/errx's as well. > On Oct 1, 2014, at 13:06, Fritjof Bornebusch wrote: > >> On Wed, Oct 01, 2014 at 06:41:25PM +0100, Nicholas Marriott wrote:

Re: [Patch] use exit() directly in usage()

2014-10-01 Thread Nicholas Marriott
Please do not change to EXIT_FAILURE. Original message From: "Kent R. Spillner" Date: 01/10/2014 23:41 (GMT+00:00) To: Fritjof Bornebusch Cc: Nicholas Marriott ,tech@openbsd.org,o...@openbsd.org Subject: Re: [Patch] use exit() directly in usage() ok kspil

Re: [Patch] use exit() directly in usage()

2014-10-01 Thread Fritjof Bornebusch
On Wed, Oct 01, 2014 at 06:41:25PM +0100, Nicholas Marriott wrote: > Looks good but you have missed out ident.c and rcsprog.c > Ups, sorry. > > > On Wed, Oct 01, 2014 at 11:19:29AM +0200, Fritjof Bornebusch wrote: > > On Sat, Sep 27, 2014 at 07:10:01PM +0200, Fritjof Bornebusch wrote: > > Hi,

Re: [Patch] use exit() directly in usage()

2014-10-01 Thread Nicholas Marriott
Looks good but you have missed out ident.c and rcsprog.c On Wed, Oct 01, 2014 at 11:19:29AM +0200, Fritjof Bornebusch wrote: > On Sat, Sep 27, 2014 at 07:10:01PM +0200, Fritjof Bornebusch wrote: > Hi, > > > Hi, > > > > after usage() was called, there is no where you can go. > > > > as suggest

Re: [Patch] use exit() directly in usage()

2014-10-01 Thread Fritjof Bornebusch
On Sat, Sep 27, 2014 at 07:10:01PM +0200, Fritjof Bornebusch wrote: Hi, > Hi, > > after usage() was called, there is no where you can go. > as suggested by otto@ and @nicm, the usage() functions are marked as __dead. > fritjof > fritjof Index: ci.c ===

Re: [Patch] use exit() directly in usage()

2014-09-30 Thread Otto Moerbeek
On Tue, Sep 30, 2014 at 10:05:00AM +0100, Nicholas Marriott wrote: > If we do this then these usage functions also need to be marked __dead. Agreed, Fritjof, can you aadd that to your diff? -Otto > > > > On Sat, Sep 27, 2014 at 07:10:01PM +0200, Fritjof Bornebusch wrote: > > Hi, > >

Re: [Patch] use exit() directly in usage()

2014-09-30 Thread Nicholas Marriott
If we do this then these usage functions also need to be marked __dead. On Sat, Sep 27, 2014 at 07:10:01PM +0200, Fritjof Bornebusch wrote: > Hi, > > after usage() was called, there is no where you can go. > > fritjof > > > Index: ci.c > ==

[Patch] use exit() directly in usage()

2014-09-27 Thread Fritjof Bornebusch
Hi, after usage() was called, there is no where you can go. fritjof Index: ci.c === RCS file: /cvs/src/usr.bin/rcs/ci.c,v retrieving revision 1.217 diff -u -p -r1.217 ci.c --- ci.c19 May 2014 19:42:24 - 1.217 +++ c