Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-30 Thread Giovanni Bechis
On 12/30/20 9:27 AM, Martijn van Duren wrote: > On Tue, 2020-12-29 at 08:57 +0100, Giovanni Bechis wrote: >> On 12/20/20 12:21 AM, gil...@poolp.org wrote: >>> December 19, 2020 11:26 PM, "Martijn van Duren" >>> wrote: >>> Personally I'd rather wait to keep the names in sync, especially since

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-30 Thread Todd C . Miller
On Wed, 30 Dec 2020 09:27:34 +0100, Martijn van Duren wrote: > On Tue, 2020-12-29 at 08:57 +0100, Giovanni Bechis wrote: > > On 12/20/20 12:21 AM, gil...@poolp.org wrote: > > > December 19, 2020 11:26 PM, "Martijn van Duren" alat.at> wrote: > > > > > > > Personally I'd rather wait to keep the na

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-30 Thread Martijn van Duren
On Tue, 2020-12-29 at 08:57 +0100, Giovanni Bechis wrote: > On 12/20/20 12:21 AM, gil...@poolp.org wrote: > > December 19, 2020 11:26 PM, "Martijn van Duren" > > wrote: > > > > > Personally I'd rather wait to keep the names in sync, especially since > > > it's an easy 2 line diff that can easily

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-30 Thread Giovanni Bechis
On 12/20/20 12:21 AM, gil...@poolp.org wrote: > December 19, 2020 11:26 PM, "Martijn van Duren" > wrote: > >> Personally I'd rather wait to keep the names in sync, especially since >> it's an easy 2 line diff that can easily be incorperated in the bigger >> thing. But it's not something I'm goin

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-27 Thread gilles
it's slightly different: ca is for "crypto agent" unsure if there's really an interest in renaming internally, furthermore there's a separate crypto API for encrypted queue so not distinguishing between crypto api and crypto agent might be confusing. Gilles December 27, 2020 5:43 PM, "Martijn

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-27 Thread Martijn van Duren
In that case fine by me. Anyone else want to chime in? On Sun, 2020-12-27 at 17:04 +, gil...@poolp.org wrote: > it's slightly different: > > ca is for "crypto agent" unsure if there's really an interest in renaming > internally, > furthermore there's a separate crypto API for encrypted queue

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-27 Thread Martijn van Duren
This one reads OK to me, with one minor bikeshed: You rename klondike to crypto, but the internals still refer to CA everywhere. Wouldn't it be cleaner to leave klondike in step one and do a s/CA/CRYPTO/ in a second step so everything is in concent? Personally I prefer the name crypto over ca. mar

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-19 Thread gilles
December 19, 2020 11:26 PM, "Martijn van Duren" wrote: > Personally I'd rather wait to keep the names in sync, especially since > it's an easy 2 line diff that can easily be incorperated in the bigger > thing. But it's not something I'm going to loose sleep over if others > thing it can go in ri

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-19 Thread gilles
I agree but I thought this should be done in a second time as it is quite invasive and not required for the change to be visible outside the daemon December 19, 2020 11:13 PM, "Martijn van Duren" wrote: > I'm in favour of this change, since I like proper nomenclature. > But I think you should

[diff] src/usr.sbin/smtpd: change process names

2020-12-19 Thread gilles
Hello, A very long time ago, smtpd had several more processes which then got factored into a single one. We couldn't find a decent name back then but since a hacker had requested a pony from me I temporarily named the process "pony express" as it was in charge of delivering mail. Later, reyk impro

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-19 Thread Todd C . Miller
I like it. I always forget which role the pony process performs. - todd

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-19 Thread Martijn van Duren
Personally I'd rather wait to keep the names in sync, especially since it's an easy 2 line diff that can easily be incorperated in the bigger thing. But it's not something I'm going to loose sleep over if others thing it can go in right now. On Sat, 2020-12-19 at 22:22 +, gil...@poolp.org wrot

Re: [diff] src/usr.sbin/smtpd: change process names

2020-12-19 Thread Martijn van Duren
I'm in favour of this change, since I like proper nomenclature. But I think you should push this one to its logical conclusion and also rename the enum and potential other pony/klondike references, because with your diff the naming is inconsistent, which is even more confusing. martijn@ On Sat, 2