Re: [patch/route] Allow short commands

2017-07-27 Thread Denis Fondras
> > +1 for a specific alias for "del" though. > > I also worry about this. However the addition of a few well-selected > shortenings is OK. > Here is a patch that adds the "del" shortcut. I am not sure the usage() et man are changed the "right way" though. Index: keywords.h ===

Re: [patch/route] Allow short commands

2017-07-27 Thread Theo de Raadt
> > I took bgpctl as an example. If there is an ambiguity, route(8) will > > complain. > > As stated in the man "Commands may be abbreviated to the minimum unambiguous > > prefix". I guess the shortcuts are to be used only interactively. Using the > > longer keyword in a script or in hostname.if i

Re: [patch/route] Allow short commands

2017-07-27 Thread Jeremie Courreges-Anglas
On Thu, Jul 27 2017, Stuart Henderson wrote: > On 2017/07/27 19:53, Denis Fondras wrote: >> Thank you for your comment. >> >> > This will lead to usage and documentation issues (aside from your >> > diff not including a manpage change): >> > >> >> You are right, I missed the manpage bits. >> >>

Re: [patch/route] Allow short commands

2017-07-27 Thread Stuart Henderson
On 2017/07/27 19:53, Denis Fondras wrote: > Thank you for your comment. > > > This will lead to usage and documentation issues (aside from your > > diff not including a manpage change): > > > > You are right, I missed the manpage bits. > > > With your diff, someone might write somewhere > > > >

Re: [patch/route] Allow short commands

2017-07-27 Thread Denis Fondras
Thank you for your comment. > This will lead to usage and documentation issues (aside from your > diff not including a manpage change): > You are right, I missed the manpage bits. > With your diff, someone might write somewhere > > just type "route a default 192.0.2.1" to configure a default r

Re: [patch/route] Allow short commands

2017-07-27 Thread Sebastian Benoit
Denis Fondras(open...@ledeuns.net) on 2017.07.26 18:42:13 +0200: > Hi, > > I use route(8) a lot and I thought being able to use shorter commands/keywords > could be nice. Like : > > route a default 192.0.2.1 > route del default > > Regards, > Denis This will lead to usage and documentation issu

[patch/route] Allow short commands

2017-07-26 Thread Denis Fondras
Hi, I use route(8) a lot and I thought being able to use shorter commands/keywords could be nice. Like : route a default 192.0.2.1 route del default Regards, Denis Index: route.c === RCS file: /cvs/src/sbin/route/route.c,v retriev