Re: [patch] tcpdump print-tcp printf format tweaks

2015-11-05 Thread Jérémie Courrèges-Anglas
Kevin Reay writes: >> > Attempted to match printf formating of unsigned 32bits to rest of >> > file. >> >> I don't think this is the good direction. "seq" and "length" are 32bits >> integers. Why cast them to long, and then print them as unsigned long? >> Let's just print them as unsigned int.

Re: [patch] tcpdump print-tcp printf format tweaks

2015-11-04 Thread Kevin Reay
> > Attempted to match printf formating of unsigned 32bits to rest of > > file. > > I don't think this is the good direction. "seq" and "length" are 32bits > integers. Why cast them to long, and then print them as unsigned long? > Let's just print them as unsigned int. That sounds good to me. I

Re: [patch] tcpdump print-tcp printf format tweaks

2015-11-04 Thread Jérémie Courrèges-Anglas
Kevin Reay writes: > Change printf format to print unsigned values. Minor spacing change of > casts to match file/style(9). > > Attempted to match printf formating of unsigned 32bits to rest of > file. I don't think this is the good direction. "seq" and "length" are 32bits integers. Why cast t

[patch] tcpdump print-tcp printf format tweaks

2015-11-02 Thread Kevin Reay
Change printf format to print unsigned values. Minor spacing change of casts to match file/style(9). Attempted to match printf formating of unsigned 32bits to rest of file. Index: print-tcp.c === RCS file: /cvs/src/usr.sbin/tcpdump/pr