Re: Add more errnos to ober_read_elements

2020-09-03 Thread Theo Buehler
On Thu, Sep 03, 2020 at 08:47:58PM +0200, Martijn van Duren wrote: > Apparently I missed one... I double checked more carefully this time, and I think you got them all now. ok tb

Re: Add more errnos to ober_read_elements

2020-09-03 Thread Martijn van Duren
Apparently I missed one... On Thu, 2020-09-03 at 18:00 +0200, Martijn van Duren wrote: > Just reminded myself of this one. > The manpage says nothing about ober_read_elements setting errno upon > failure, yet it does in most cases. Furthermore, applications like > snmpd use errno in ober_read_elem

Re: Add more errnos to ober_read_elements

2020-09-03 Thread Theo de Raadt
Yep. Martijn van Duren wrote: > Just reminded myself of this one. > The manpage says nothing about ober_read_elements setting errno upon > failure, yet it does in most cases. Furthermore, applications like > snmpd use errno in ober_read_elements to determine if a read is > incomplete (checking f

Add more errnos to ober_read_elements

2020-09-03 Thread Martijn van Duren
Just reminded myself of this one. The manpage says nothing about ober_read_elements setting errno upon failure, yet it does in most cases. Furthermore, applications like snmpd use errno in ober_read_elements to determine if a read is incomplete (checking for ECANCELED), without initializing errno t