Re: Add white temperature balance adjustability to video(1)

2020-07-15 Thread Marcus Glocker
On Wed, 15 Jul 2020 21:15:37 +0100 Laurence Tratt wrote: > On Wed, Jul 15, 2020 at 08:33:54PM +0200, Marcus Glocker wrote: > > Hello Marcus, > > Thanks for your comments. I agree with all but one, and attach a new > diff. > > >> +#define CTRL_WHITE_BALANCE_TEMPERATURE 7 > >> + { "white_balanc

Re: Add white temperature balance adjustability to video(1)

2020-07-15 Thread Laurence Tratt
On Wed, Jul 15, 2020 at 08:33:54PM +0200, Marcus Glocker wrote: Hello Marcus, Thanks for your comments. I agree with all but one, and attach a new diff. >> +#define CTRL_WHITE_BALANCE_TEMPERATURE 7 >> +{ "white_balance_temperature", > I think we should replace '_' with ' ' just to make the o

Re: Add white temperature balance adjustability to video(1)

2020-07-15 Thread Marcus Glocker
Oh, and lastly I forget, we would need a man page update as well listing the new knob :-) On Wed, 15 Jul 2020 20:33:54 +0200 Marcus Glocker wrote: > Thanks for the diff Laurie - See my comments inline in your diff. > > Marcus > > On Mon, 13 Jul 2020 17:19:41 +0100 > Laurence Tratt wrote: > >

Re: Add white temperature balance adjustability to video(1)

2020-07-15 Thread Marcus Glocker
Thanks for the diff Laurie - See my comments inline in your diff. Marcus On Mon, 13 Jul 2020 17:19:41 +0100 Laurence Tratt wrote: > This patch adds the ability to control the white balance temperature > on webcams in video(1). This is bound to keys W/w in steps of +/-10K > (because changing the

Add white temperature balance adjustability to video(1)

2020-07-13 Thread Laurence Tratt
This patch adds the ability to control the white balance temperature on webcams in video(1). This is bound to keys W/w in steps of +/-10K (because changing the temperature 1K at a time is tortuously slow given a typical range of 2800-6500K, and +/-10 seems to roughly be the minimum difference that