Does this look good? I'm not sure why these globals existed.
It looks like it's going to take a little more than search-and-replace
to remove null.
Index: c_ksh.c
===
RCS file: /cvs/src/bin/ksh/c_ksh.c,v
retrieving revision 1.36
Michael McConville sccs.swarthmore.edu> writes:
> RCS file: /cvs/src/bin/ksh/c_ksh.c,v
> - shprintf(newline);
> + shprintf("\n");
In terms of portability, are you sure newline is \n on all platforms?
Alexey Suslikov wrote:
> Michael McConville sccs.swarthmore.edu> writes:
>
> > RCS file: /cvs/src/bin/ksh/c_ksh.c,v
>
>
>
> > - shprintf(newline);
> > + shprintf("\n");
>
> In terms of portability, are you sure newline is \n on all platforms?
I'm not. Do
looks good to me, any other ok?
null is serious poo and really needs to go as well
On Thu, Sep 10, 2015 at 10:45:46AM -0400, Michael McConville wrote:
> Does this look good? I'm not sure why these globals existed.
>
> It looks like it's going to take a little more than search-and-replace
> to
Hi
On Thu, Sep 10, 2015 at 04:33:07PM -0600, Todd C. Miller wrote:
> On Thu, 10 Sep 2015 23:26:53 +0100, Nicholas Marriott wrote:
>
> > looks good to me, any other ok?
> >
> > null is serious poo and really needs to go as well
>
> Beware! Some of these values are used in pointer comparisons
Todd C. Miller wrote:
> On Thu, 10 Sep 2015 23:26:53 +0100, Nicholas Marriott wrote:
> > looks good to me, any other ok?
> >
> > null is serious poo and really needs to go as well
>
> Beware! Some of these values are used in pointer comparisons so
> I'm not sure it is same to remove them.
>
>
On Thu, 10 Sep 2015 23:43:15 +0100, Nicholas Marriott wrote:
> ok then?
OK for removing newline (and space too).
- todd
On Thu, 10 Sep 2015 23:26:53 +0100, Nicholas Marriott wrote:
> looks good to me, any other ok?
>
> null is serious poo and really needs to go as well
Beware! Some of these values are used in pointer comparisons so
I'm not sure it is same to remove them.
I don't see any comparisons with
Michael McConville wrote:
> Alexey Suslikov wrote:
> > Michael McConville sccs.swarthmore.edu> writes:
> >
> > > RCS file: /cvs/src/bin/ksh/c_ksh.c,v
> >
> >
> >
> > > - shprintf(newline);
> > > + shprintf("\n");
> >
> > In terms of portability, are you sure
