Re: Fix acpi(4) GeneralSerialBus implementation

2018-05-19 Thread Mike Larkin
On Sat, May 19, 2018 at 09:25:47AM +0200, Mark Kettenis wrote: > > Date: Fri, 18 May 2018 22:21:06 -0700 > > From: Mike Larkin > > > > > @@ -2564,6 +2564,14 @@ aml_rwgsb(struct aml_value *conn, int bp > > > cmdlen = 1; > > > buflen = 2; >

Re: Fix acpi(4) GeneralSerialBus implementation

2018-05-19 Thread Mark Kettenis
> Date: Fri, 18 May 2018 22:21:06 -0700 > From: Mike Larkin > > > @@ -2564,6 +2564,14 @@ aml_rwgsb(struct aml_value *conn, int bp > > cmdlen = 1; > > buflen = 2; > > break; > > + case 0x0b: /*

Re: Fix acpi(4) GeneralSerialBus implementation

2018-05-18 Thread Mike Larkin
On Fri, May 18, 2018 at 08:53:41PM +0200, Mark Kettenis wrote: > Turns out there is an alternate way to encode > AttribBytes/AttribRawBytes (and AttribRawProcessBytes) that I didn't > implement. In fact our parsing of fields has always been wrong when > this alternative encoding is present. But

Fix acpi(4) GeneralSerialBus implementation

2018-05-18 Thread Mark Kettenis
Turns out there is an alternate way to encode AttribBytes/AttribRawBytes (and AttribRawProcessBytes) that I didn't implement. In fact our parsing of fields has always been wrong when this alternative encoding is present. But for some reason we lucked out the parser didn't go fully off the rails.