Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-08-16 Thread Vincent Gross
On Thu, 11 Aug 2016 16:57:27 +0100 Stuart Henderson wrote: > On 2016/06/27 13:00, Jérémie Courrèges-Anglas wrote: > > Stuart Henderson writes: > > [...] > > > > > > Basically yes but one observation. > > > > I also gave my ok to vgross by IM. > > > > I know that some concerns have been ex

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-08-11 Thread Stuart Henderson
On 2016/06/27 13:00, Jérémie Courrèges-Anglas wrote: > Stuart Henderson writes: > > > On 2016/06/15 19:43, Vincent Gross wrote: > >> On Mon, 13 Jun 2016 16:49:01 +0200 > >> Vincent Gross wrote: > >> > > >> > While validating source address inside selection functions is the > >> > right directio

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-27 Thread Jérémie Courrèges-Anglas
Stuart Henderson writes: > On 2016/06/15 19:43, Vincent Gross wrote: >> On Mon, 13 Jun 2016 16:49:01 +0200 >> Vincent Gross wrote: >> > >> > While validating source address inside selection functions is the >> > right direction, I don't think it would be a good thing to extend >> > further in_s

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-23 Thread Stuart Henderson
On 2016/06/15 19:43, Vincent Gross wrote: > On Mon, 13 Jun 2016 16:49:01 +0200 > Vincent Gross wrote: > > > > While validating source address inside selection functions is the > > right direction, I don't think it would be a good thing to extend > > further in_selectsrc() prototype. However it is

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-19 Thread Alexander Bluhm
On Wed, Jun 15, 2016 at 07:43:37PM +0200, Vincent Gross wrote: > rev3 below. > > I fixed the line length, the useless bzero(), and also the wording in > ip.4 > > Ok ? OK bluhm@ > > Index: sys/netinet/in.h > === > RCS file: /cvs/sr

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-15 Thread Vincent Gross
On Mon, 13 Jun 2016 16:49:01 +0200 Vincent Gross wrote: > > While validating source address inside selection functions is the > right direction, I don't think it would be a good thing to extend > further in_selectsrc() prototype. However it is easy to add a check > while processing cmsg. > > rev

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-14 Thread Jeremie Courreges-Anglas
Martin Pieuchot writes: > On 14/06/16(Tue) 13:49, Jeremie Courreges-Anglas wrote: >> Vincent Gross writes: >> > On Mon, 13 Jun 2016 19:57:15 +0200 >> > Jeremie Courreges-Anglas wrote: >> >> Vincent Gross writes: >> >> > Le Mon, 13 Jun 2016 07:35:16 +0200, >> >> > j...@wxcvbn.org (Jeremie Courr

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-14 Thread Martin Pieuchot
On 14/06/16(Tue) 13:49, Jeremie Courreges-Anglas wrote: > Vincent Gross writes: > > On Mon, 13 Jun 2016 19:57:15 +0200 > > Jeremie Courreges-Anglas wrote: > >> Vincent Gross writes: > >> > Le Mon, 13 Jun 2016 07:35:16 +0200, > >> > j...@wxcvbn.org (Jeremie Courreges-Anglas) a écrit : > >> >> j..

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-14 Thread Jeremie Courreges-Anglas
Vincent Gross writes: > On Mon, 13 Jun 2016 19:57:15 +0200 > Jeremie Courreges-Anglas wrote: > >> Vincent Gross writes: >> >> > Le Mon, 13 Jun 2016 07:35:16 +0200, >> > j...@wxcvbn.org (Jeremie Courreges-Anglas) a écrit : >> > >> >> j...@wxcvbn.org (Jeremie Courreges-Anglas) writes: >> >>

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-13 Thread Vincent Gross
On Mon, 13 Jun 2016 19:57:15 +0200 Jeremie Courreges-Anglas wrote: > Vincent Gross writes: > > > Le Mon, 13 Jun 2016 07:35:16 +0200, > > j...@wxcvbn.org (Jeremie Courreges-Anglas) a écrit : > > > >> j...@wxcvbn.org (Jeremie Courreges-Anglas) writes: > >> > >> > cc'ing sthen since he also h

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-13 Thread Jeremie Courreges-Anglas
Vincent Gross writes: > Le Mon, 13 Jun 2016 07:35:16 +0200, > j...@wxcvbn.org (Jeremie Courreges-Anglas) a écrit : > >> j...@wxcvbn.org (Jeremie Courreges-Anglas) writes: >> >> > cc'ing sthen since he also has interest in IP_SENDSRCADDR >> > >> > Jeremie Courreges-Anglas writes: >> > >> >> Vi

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-13 Thread Vincent Gross
Le Mon, 13 Jun 2016 07:35:16 +0200, j...@wxcvbn.org (Jérémie Courrèges-Anglas) a écrit : > j...@wxcvbn.org (Jeremie Courreges-Anglas) writes: > > > cc'ing sthen since he also has interest in IP_SENDSRCADDR > > > > Jeremie Courreges-Anglas writes: > > > >> Vincent Gross writes: > >> > >>> Th

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-12 Thread Jeremie Courreges-Anglas
Vincent Gross writes: > On Sun, 12 Jun 2016 15:29:32 +0200 (CEST) > Mark Kettenis wrote: > >> > Date: Sun, 12 Jun 2016 14:59:55 +0200 >> > From: Vincent Gross >> > >> > This diff adds support for IP_SENDSRCADDR cmsg on UDP sockets. As >> > for udp6_output(), we check that the source address+po

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-12 Thread Reyk Floeter
> Am 12.06.2016 um 16:36 schrieb Vincent Gross : > > On Sun, 12 Jun 2016 15:29:32 +0200 (CEST) > Mark Kettenis wrote: > >>> Date: Sun, 12 Jun 2016 14:59:55 +0200 >>> From: Vincent Gross >>> >>> This diff adds support for IP_SENDSRCADDR cmsg on UDP sockets. As >>> for udp6_output(), we check t

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-12 Thread Vincent Gross
On Sun, 12 Jun 2016 15:29:32 +0200 (CEST) Mark Kettenis wrote: > > Date: Sun, 12 Jun 2016 14:59:55 +0200 > > From: Vincent Gross > > > > This diff adds support for IP_SENDSRCADDR cmsg on UDP sockets. As > > for udp6_output(), we check that the source address+port is > > available only if inp_la

Re: IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-12 Thread Mark Kettenis
> Date: Sun, 12 Jun 2016 14:59:55 +0200 > From: Vincent Gross > > This diff adds support for IP_SENDSRCADDR cmsg on UDP sockets. As for > udp6_output(), we check that the source address+port is available only > if inp_laddr != * > > Ok ? Why do we need this? cmsg stuff is fragile, so we want t

IP_SENDSRCADDR [2/2] : add cmsg support

2016-06-12 Thread Vincent Gross
This diff adds support for IP_SENDSRCADDR cmsg on UDP sockets. As for udp6_output(), we check that the source address+port is available only if inp_laddr != * Ok ? diff --git a/share/man/man4/ip.4 b/share/man/man4/ip.4 index 111432b..154b0d1 100644 --- a/share/man/man4/ip.4 +++ b/share/man/man4/i