Re: KASSERT() @ pf_test() is back

2016-03-07 Thread Alexandr Nedvedicky
On Mon, Mar 07, 2016 at 10:54:26AM +0100, Mattieu Baptiste wrote: > On Mon, Mar 7, 2016 at 10:03 AM, Alexandr Nedvedicky > wrote: > > Hello Mattieu, > > > > Mark Patruck reported panic on KASSERT() in pf_test() yesterday . I've > > crafted > > patch below. Can you

Re: KASSERT() @ pf_test() is back

2016-03-07 Thread Mattieu Baptiste
On Mon, Mar 7, 2016 at 10:03 AM, Alexandr Nedvedicky wrote: > Hello Mattieu, > > Mark Patruck reported panic on KASSERT() in pf_test() yesterday . I've crafted > patch below. Can you try it out? > > I think we need to apply pf_pkt_addr_changed() on broadcast

Re: KASSERT() @ pf_test() is back

2016-03-07 Thread Alexandr Nedvedicky
Hello Mattieu, Mark Patruck reported panic on KASSERT() in pf_test() yesterday . I've crafted patch below. Can you try it out? I think we need to apply pf_pkt_addr_changed() on broadcast packets seen by bridge as well. thanks a lot and sorry for inconveniences regards sasha

Re: KASSERT() @ pf_test() is back

2016-03-06 Thread Mattieu Baptiste
On Sun, Mar 6, 2016 at 11:33 PM, Martin Pieuchot wrote: > On 06/03/16(Sun) 22:35, Mattieu Baptiste wrote: >> On Sun, Mar 6, 2016 at 10:22 PM, Martin Pieuchot wrote: >> > On 06/03/16(Sun) 19:57, Mattieu Baptiste wrote: >> >> [...] >> >> As discussed in january,

Re: KASSERT() @ pf_test() is back

2016-03-06 Thread Martin Pieuchot
On 06/03/16(Sun) 22:35, Mattieu Baptiste wrote: > On Sun, Mar 6, 2016 at 10:22 PM, Martin Pieuchot wrote: > > On 06/03/16(Sun) 19:57, Mattieu Baptiste wrote: > >> [...] > >> As discussed in january, with the patches committed, -current still > >> panics for me: > >>

Re: KASSERT() @ pf_test() is back

2016-03-06 Thread Mattieu Baptiste
On Sun, Mar 6, 2016 at 10:22 PM, Martin Pieuchot wrote: > On 06/03/16(Sun) 19:57, Mattieu Baptiste wrote: >> [...] >> As discussed in january, with the patches committed, -current still >> panics for me: >> http://www.brimbelle.org/mattieu/stuff/panic_statekey/panic10.jpg >>

Re: KASSERT() @ pf_test() is back

2016-03-06 Thread Martin Pieuchot
On 06/03/16(Sun) 19:57, Mattieu Baptiste wrote: > [...] > As discussed in january, with the patches committed, -current still > panics for me: > http://www.brimbelle.org/mattieu/stuff/panic_statekey/panic10.jpg > http://www.brimbelle.org/mattieu/stuff/panic_statekey/panic11.jpg >

Re: KASSERT() @ pf_test() is back

2016-03-06 Thread Mattieu Baptiste
On Fri, Mar 4, 2016 at 2:31 PM, Alexandr Nedvedicky wrote: > Hello Stuart, > > thanks for testing it. I'll commit it today. > Hi Alexandr, As discussed in january, with the patches committed, -current still panics for me:

Re: KASSERT() @ pf_test() is back

2016-03-04 Thread Alexandr Nedvedicky
Hello Stuart, thanks for testing it. I'll commit it today. regards sasha On Fri, Mar 04, 2016 at 01:08:42AM +, Stuart Henderson wrote: > On 2016/02/28 13:01, Martin Pieuchot wrote: > > On 08/02/16(Mon) 01:55, Alexandr Nedvedicky wrote: > > > Hello, > > > > > > I don't expect to see O.K. to

Re: KASSERT() @ pf_test() is back

2016-02-28 Thread Martin Pieuchot
On 08/02/16(Mon) 01:55, Alexandr Nedvedicky wrote: > Hello, > > I don't expect to see O.K. to patch below. > > The patch is the part of the change, which has been backed out last weekend. > Too many things were wrong so I'm trying to untangle the code a bit. > > Patch below is for brave hearts,

KASSERT() @ pf_test() is back

2016-02-07 Thread Alexandr Nedvedicky
Hello, I don't expect to see O.K. to patch below. The patch is the part of the change, which has been backed out last weekend. Too many things were wrong so I'm trying to untangle the code a bit. Patch below is for brave hearts, who don't mind to see KASSERT() to fire: Index: net/pf.c