Re: LLVM warning in dev/ic/uhci.c

2013-12-05 Thread Brad Smith
On Wed, Dec 04, 2013 at 05:04:13PM +0100, Mark Kettenis wrote: > > Date: Wed, 4 Dec 2013 12:53:20 +0100 > > From: Joerg Sonnenberger > > > > On Wed, Dec 04, 2013 at 12:24:50PM +0100, Mark Kettenis wrote: > > > Sorry, but I disagree with LLVM here. It shouldn't complain about > > > static inline

Re: LLVM warning in dev/ic/uhci.c

2013-12-04 Thread Mark Kettenis
> Date: Wed, 4 Dec 2013 12:53:20 +0100 > From: Joerg Sonnenberger > > On Wed, Dec 04, 2013 at 12:24:50PM +0100, Mark Kettenis wrote: > > Sorry, but I disagree with LLVM here. It shouldn't complain about > > static inline functions. > > Then mark them as unused, just like you would with a static

Re: LLVM warning in dev/ic/uhci.c

2013-12-04 Thread Joerg Sonnenberger
On Wed, Dec 04, 2013 at 12:24:50PM +0100, Mark Kettenis wrote: > Sorry, but I disagree with LLVM here. It shouldn't complain about > static inline functions. Then mark them as unused, just like you would with a static variable you insist on keeping. Joerg

Re: LLVM warning in dev/ic/uhci.c

2013-12-04 Thread Mark Kettenis
> Date: Tue, 3 Dec 2013 17:55:00 -0500 > From: Brad Smith > > Put UREAD4 under #ifdef UHCI_DEBUG as it is only used by a function > for debugging which is also under UHCI_DEBUG. > > uhci.c:256:1: error: unused function 'UREAD4' [-Werror,-Wunused-function] > > OK? Sorry, but I disagree with LLV

LLVM warning in dev/ic/uhci.c

2013-12-03 Thread Brad Smith
Put UREAD4 under #ifdef UHCI_DEBUG as it is only used by a function for debugging which is also under UHCI_DEBUG. uhci.c:256:1: error: unused function 'UREAD4' [-Werror,-Wunused-function] OK? Index: uhci.c === RCS file: /home/cvs/s