Re: NEW: libc getdelim(3) and getline(3)

2012-03-12 Thread Jan Klemkow
The return of EINVAL on fp NULL comes from me. I think its even an invalid argument like the other pointers. The rest should be fine now. Thank you. On Thu, Mar 08, 2012 at 02:15:28AM +, Federico Schwindt wrote: On Wed, Mar 7, 2012 at 7:42 AM, Jan Klemkow j.klem...@wemelug.de wrote: Hi

Re: NEW: libc getdelim(3) and getline(3)

2012-03-12 Thread Mark Kettenis
Date: Mon, 12 Mar 2012 13:45:58 +0100 From: Jan Klemkow j.klem...@wemelug.de The return of EINVAL on fp NULL comes from me. I think its even an invalid argument like the other pointers. We tend to take the position that it is better to crash hard that return an error if an invalid argument

Re: NEW: libc getdelim(3) and getline(3)

2012-03-12 Thread Jan Klemkow
sounds reasonable. On Mon, Mar 12, 2012 at 02:18:42PM +0100, Mark Kettenis wrote: Date: Mon, 12 Mar 2012 13:45:58 +0100 From: Jan Klemkow j.klem...@wemelug.de The return of EINVAL on fp NULL comes from me. I think its even an invalid argument like the other pointers. We tend to

Re: NEW: libc getdelim(3) and getline(3)

2012-03-12 Thread Federico Schwindt
On Mon, Mar 12, 2012 at 1:18 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Mon, 12 Mar 2012 13:45:58 +0100 From: Jan Klemkow j.klem...@wemelug.de The return of EINVAL on fp NULL comes from me. I think its even an invalid argument like the other pointers. We tend to take the

Re: NEW: libc getdelim(3) and getline(3)

2012-03-12 Thread Mark Kettenis
Date: Mon, 12 Mar 2012 18:02:59 + From: Federico Schwindt fg...@lodoss.net On Mon, Mar 12, 2012 at 1:18 PM, Mark Kettenis mark.kette...@xs4all.nl wrote: Date: Mon, 12 Mar 2012 13:45:58 +0100 From: Jan Klemkow j.klem...@wemelug.de The return of EINVAL on fp NULL comes from me. I

Re: NEW: libc getdelim(3) and getline(3)

2012-02-29 Thread Federico Schwindt
On Tue, Feb 28, 2012 at 10:12 AM, Jan Klemkow j.klem...@wemelug.de wrote: Here is my diff for the renaming of the getline function in base. Please, test it and tell me everything that is wrong with it. Thanks for the diff. I will let you know if there are any problems, otherwise it will be

Re: NEW: libc getdelim(3) and getline(3)

2012-02-28 Thread Jan Klemkow
Here is my diff for the renaming of the getline function in base. Please, test it and tell me everything that is wrong with it. -- Jan Index: bin/pax/options.c === RCS file: /cvs/src/bin/pax/options.c,v retrieving revision 1.74

Re: NEW: libc getdelim(3) and getline(3)

2012-02-26 Thread Steffen Daode Nurpmeso
pax(1). --steffen Index: bin/pax/options.c === RCS file: /Users/steffen/arena/code.openbsd/src/bin/pax/options.c,v retrieving revision 1.74 diff -a -p -u -r1.74 options.c --- bin/pax/options.c 2 Dec 2010 04:08:27 - 1.74

Re: NEW: libc getdelim(3) and getline(3)

2012-02-26 Thread Steffen Daode Nurpmeso
unifdef(1). (Should complete bin and usr.bin.) (Did i press 'g' all the time? Sorry if not!) --steffen Index: usr.bin/unifdef/unifdef.c === RCS file: /Users/steffen/arena/code.openbsd/src/usr.bin/unifdef/unifdef.c,v retrieving

Re: NEW: libc getdelim(3) and getline(3)

2012-02-26 Thread Steffen Daode Nurpmeso
(All compile-tested after applying the patches.) --steffen

Re: NEW: libc getdelim(3) and getline(3)

2012-02-25 Thread Steffen Daode Nurpmeso
uudecode(1). --steffen Index: usr.bin/uudecode/uudecode.c === RCS file: /Users/steffen/arena/code.openbsd/src/usr.bin/uudecode/uudecode.c,v retrieving revision 1.17 diff -a -p -u -r1.17 uudecode.c --- usr.bin/uudecode/uudecode.c 27

Re: NEW: libc getdelim(3) and getline(3)

2012-02-25 Thread Steffen Daode Nurpmeso
lpr(1). --steffen Index: usr.sbin/lpr/common_source/common.c === RCS file: /Users/steffen/arena/code.openbsd/src/usr.sbin/lpr/common_source/common.c,v retrieving revision 1.33 diff -a -p -u -r1.33 common.c ---

Re: NEW: libc getdelim(3) and getline(3)

2012-02-25 Thread Steffen Daode Nurpmeso
diff3(1). --steffen Index: usr.bin/diff3/diff3prog.c === RCS file: /Users/steffen/arena/code.openbsd/src/usr.bin/diff3/diff3prog.c,v retrieving revision 1.11 diff -a -p -u -r1.11 diff3prog.c --- usr.bin/diff3/diff3prog.c 27 Oct

Re: NEW: libc getdelim(3) and getline(3)

2012-02-25 Thread Christian Weisgerber
Philip Guenther guent...@gmail.com wrote: Now that the base is unlocked, we can consider diffs to a) rename getdelim() and getline() symbols that are already in the tree, and b) add getdelim() and getline() to libc. Note that (a) will need to go in before (b)... I also expect some fallout

Re: NEW: libc getdelim(3) and getline(3)

2012-02-25 Thread Antoine Jacoutot
On Sat, Feb 25, 2012 at 04:50:21PM +, Christian Weisgerber wrote: Philip Guenther guent...@gmail.com wrote: Now that the base is unlocked, we can consider diffs to a) rename getdelim() and getline() symbols that are already in the tree, and b) add getdelim() and getline() to libc.

Re: NEW: libc getdelim(3) and getline(3)

2012-02-24 Thread Philip Guenther
Now that the base is unlocked, we can consider diffs to a) rename getdelim() and getline() symbols that are already in the tree, and b) add getdelim() and getline() to libc. Note that (a) will need to go in before (b)... Philip Guenther

Re: NEW: libc getdelim(3) and getline(3)

2012-02-03 Thread Antoine Jacoutot
On Fri, Feb 03, 2012 at 05:00:55PM +0100, Jan Klemkow wrote: I decide to remove the check for the negative delimiter character, but I am not sure, with the file handle pointer check!? In my opinion this should be checked and return an minus 1 with an error for invalid input. The realloc(2)

NEW: libc getdelim(3) and getline(3)

2012-01-26 Thread Jan Klemkow
Hello, I miss some std libc functions in OpenBSD. So, I deside to implement a few of them by myself. This is a diff for getdelim(3) and getline(3). Which are described here: http://pubs.opengroup.org/onlinepubs/9699919799/functions/getdelim.html The manpage tooked from NetBSD, because I am not

Re: NEW: libc getdelim(3) and getline(3)

2012-01-26 Thread Brad
On 26/01/12 5:03 PM, Jan Klemkow wrote: Hello, I miss some std libc functions in OpenBSD. So, I deside to implement a few of them by myself. This is a diff for getdelim(3) and getline(3). Which are described here: http://pubs.opengroup.org/onlinepubs/9699919799/functions/getdelim.html Seeing

Re: NEW: libc getdelim(3) and getline(3)

2012-01-26 Thread Ted Unangst
On Thu, Jan 26, 2012, Jan Klemkow wrote: I miss some std libc functions in OpenBSD. So, I deside to implement a few of them by myself. This is a diff for getdelim(3) and getline(3). it is too late for this release, I'd advise sending again once 5.1 is released. At the moment this patch