Re: PATCH: merge.c white space cleanup

2013-01-28 Thread Matthias Kilian
On Mon, Jan 28, 2013 at 08:45:19PM +0100, Marc Espie wrote: > > > Otoh this file is quite bad. It makes my vim light up all red. > > > > That's why you should stick to vi and not the emacs-in-a-vi-disguise > > bloatware known as vim. > > Lol. > > Give me a vi with multiple windows, and with visu

Re: PATCH: merge.c white space cleanup

2013-01-28 Thread Miod Vallat
> Give me a vi with multiple windows, and with visual, and I will consider > changing editors. If you need multiple windows, simply open several {rxvt,xterm,whatever} windows and run vi in them.

Re: PATCH: merge.c white space cleanup

2013-01-28 Thread Marc Espie
On Mon, Jan 28, 2013 at 07:03:24PM +, Miod Vallat wrote: > > Usually whitespace diffs are not that well liked, they make for > > annoying differences, introduce noise and require more effort to review > > for questionable gain. > > > > Otoh this file is quite bad. It makes my vim light up all

Re: PATCH: merge.c white space cleanup

2013-01-28 Thread Miod Vallat
> Usually whitespace diffs are not that well liked, they make for > annoying differences, introduce noise and require more effort to review > for questionable gain. > > Otoh this file is quite bad. It makes my vim light up all red. That's why you should stick to vi and not the emacs-in-a-vi-disgu

Re: PATCH: merge.c white space cleanup

2013-01-27 Thread Tobias Ulmer
On Thu, Jan 24, 2013 at 09:37:33PM +0200, Ville Valkonen wrote: > Hi, > > save a few precious bytes by removing unnecessary white spaces from > libc/merge.c. Please send diffs inline, it's a lot easier to review. Usually whitespace diffs are not that well liked, they make for annoying difference

PATCH: merge.c white space cleanup

2013-01-24 Thread Ville Valkonen
Hi, save a few precious bytes by removing unnecessary white spaces from libc/merge.c. http://weezel.fsck.fi/merge.patch> -- Sincerely, Ville Valkonen