Hi,
Some feedback inline:
On Tue, 28 May 2019 at 18:42:51 -0400, Cody Cutler wrote:
> Hello tech, I'm submitting the following patch for inclusion. The patch
> implements a driver for the Keyspan USA-19HS USB-to-serial dongle.
>
> I've used it for a few months now without any problems. Please le
>
> The routine for adding USB devices is to just add them to
> /usr/src/sys/dev/usb/usbdevs, then run 'make' in
> /usr/src/sys/dev/usb/. That will automatically regenerate usbdevs.h
> and usbdevs_data.h.
I'm happy to test when the new diff is submitted. I have a USA19HS
sitting in my desk.
Thank you for your comments, Joshua. I'll send an updated patch shortly.
j...@openbsd.org (joshua stein) - Tue, May 28, 2019 at 07:51:08PM -0500
> Hi,
>
> Some feedback inline:
>
> On Tue, 28 May 2019 at 18:42:51 -0400, Cody Cutler wrote:
> > Hello tech, I'm submitting the following patch for in
Hi jcs and tech, the following is a patch which implements jcs's feedback and
adds a man page.
Note that one must execute `make -C sys/dev/usb' after applying to build.
Thanks!
diff --git share/man/man4/Makefile share/man/man4/Makefile
index 7d470b6ca47..999621c7889 100644
--- share/man/man4/Mak
On Mon, Jun 03, 2019 at 11:44:37PM -0400, Cody Cutler wrote:
> Hi jcs and tech, the following is a patch which implements jcs's feedback and
> adds a man page.
>
> Note that one must execute `make -C sys/dev/usb' after applying to build.
>
> Thanks!
>
> diff --git share/man/man4/Makefile share/m
On Mon, 03 Jun 2019 at 23:44:37 -0400, Cody Cutler wrote:
> Hi jcs and tech, the following is a patch which implements jcs's feedback and
> adds a man page.
Thanks Cody, I've imported your driver.
On Fri, Jun 07, 2019 at 11:08:24AM -0500, joshua stein wrote:
> On Mon, 03 Jun 2019 at 23:44:37 -0400, Cody Cutler wrote:
> > Hi jcs and tech, the following is a patch which implements jcs's feedback
> > and
> > adds a man page.
>
> Thanks Cody, I've imported your driver.
>
/sys/dev/usb/ukspan.
