Re: ftp: use closefrom instead of close(pid)

2018-01-24 Thread Theo de Raadt
Sure. But always be careful that the fd loop isn't bounded for a reason, for instance some fd at > 20 that it wanted left open. > This variable reuse has a funny smell. > > Index: usr.bin/ftp/cmds.c > === > RCS file: /var/cvs/src/us

Re: ftp: use closefrom instead of close(pid)

2018-01-24 Thread Jeremie Courreges-Anglas
On Wed, Jan 24 2018, Theo Buehler wrote: > This variable reuse has a funny smell. ok > Index: usr.bin/ftp/cmds.c > === > RCS file: /var/cvs/src/usr.bin/ftp/cmds.c,v > retrieving revision 1.79 > diff -u -p -r1.79 cmds.c > --- usr.bin