Hi,
Removing unused code:
* arch/mac68k/include/keyboard.h not used in kernel sources
* not need define KEYBOARD_ARRAY (variable keyboard[] used only in
dev/adb/akbd.c if defined WSDISPLAY_COMPAT_RAWKBD)
OK ?
--
Alexandr Shadchin
Index: arch/mac68k/include/keyboard.h
Hi,
The uhidevsubmatch() routine was imported from NetBSD back in 2002[1] along with
the reportid locator. The same locator was removed in 2004[2] making
this routine and its defines redundant.
Comments? OK?
[1]
https://github.com/openbsd/src/commit/a66cb31e58a16ed957a52ce1b92aafc08fc4900d
[2]
> Hi,
>
> Removing unused code:
> * arch/mac68k/include/keyboard.h not used in kernel sources
ok miod@
> * not need define KEYBOARD_ARRAY (variable keyboard[] used only in
> dev/adb/akbd.c if defined WSDISPLAY_COMPAT_RAWKBD)
Not ok. arch/macppc/dev/akdb_machdep.c includes
, and will include t
On Sun, Jun 05, 2011 at 09:30:38PM +, Miod Vallat wrote:
> > Hi,
> >
> > Removing unused code:
> > * arch/mac68k/include/keyboard.h not used in kernel sources
>
> ok miod@
>
> > * not need define KEYBOARD_ARRAY (variable keyboard[] used only in
> > dev/adb/akbd.c if defined WSDISPLAY_COMPA
This is the first part of the big ipmi(4) patch I sent in another thread.
This removes complicate polling timeout code. Serial communication with BMC
is slow but considered as reliable. Communication failure is a fatal problem.
Returning error doesn't make sense.
This also removes unfinished in
Hi
While working on a patch, i noticed that vmm_get_guest_faulttype was
incorrect for amd (VMM_MODE_RVI) cpus, apon further inspection realised
it was unused. Please see the patch below to remove it.
cheers
Adam
? div
Index: sys/arch/amd64/amd64/vmm.c
I guess the intent was to get a custom message at build time which would
be shown when phantasia starts up. But --
(1) That would make the build interactive.
(2) _PATH_PHANTDIR is not defined anywhere so this won't compile.
(3) As the ifdef macro says, this can be done from the Makefile if
n
> Date: Mon, 21 Dec 2015 22:31:22 +0900
> From: Masao Uebayashi
>
> This is the first part of the big ipmi(4) patch I sent in another thread.
>
> This removes complicate polling timeout code. Serial communication
> with BMC is slow but considered as reliable. Communication failure
> is a fatal
> > diff --git a/sys/dev/ipmi.c b/sys/dev/ipmi.c
> > index a1156d8..91aa147 100644
> > --- a/sys/dev/ipmi.c
> > +++ b/sys/dev/ipmi.c
> > @@ -1082,11 +1017,7 @@ void
> > ipmi_delay(struct ipmi_softc *sc, int period)
> > {
> > /* period is in 10 ms increments */
> > - if (cold || sc->sc_poll)
On Mon, Dec 21, 2015 at 03:41:23PM +0100, Mark Kettenis wrote:
> > Date: Mon, 21 Dec 2015 22:31:22 +0900
> > From: Masao Uebayashi
> >
> > This is the first part of the big ipmi(4) patch I sent in another thread.
> >
> > This removes complicate polling timeout code. Serial communication
> > wit
FWIW, I'm not going to propose enabling ipmi(4).
Sent from my iPhone
On Dec 22, 2015, at 1:26 AM, Theo de Raadt wrote:
>>> diff --git a/sys/dev/ipmi.c b/sys/dev/ipmi.c
>>> index a1156d8..91aa147 100644
>>> --- a/sys/dev/ipmi.c
>>> +++ b/sys/dev/ipmi.c
>>> @@ -1082,11 +1017,7 @@ void
>>> ipmi_de
On Fri, Jan 31, 2020 at 01:40:14AM +, Adam Steen wrote:
> Hi
>
> While working on a patch, i noticed that vmm_get_guest_faulttype was
> incorrect for amd (VMM_MODE_RVI) cpus, apon further inspection realised
> it was unused. Please see the patch below to remove it.
>
> cheers
> Adam
>
T
debug messages should go to stderr (currently debug messages are
buffered if you send them to a pipe)
The sched.h/ncpu bits are remnants from rev 1.46. Most of this code was
then removed in rev 1.70.
ok?
--- apmd.c.~1.89.~ Thu Oct 31 22:23:07 2019
+++ apmd.c Fri Nov 1 10:07:21 201
On Fri, Nov 01, 2019 at 10:19:01AM +0100, Jeremie Courreges-Anglas wrote:
> debug messages should go to stderr (currently debug messages are
> buffered if you send them to a pipe)
>
> The sched.h/ncpu bits are remnants from rev 1.46. Most of this code was
> then removed in rev 1.70.
OK kn
14 matches
Mail list logo
