Re: Some arm cleanups suggested by clang

2016-09-24 Thread Mark Kettenis
> Date: Sat, 24 Sep 2016 14:07:00 +1000 > From: Jonathan Gray > > On Fri, Sep 23, 2016 at 01:43:04PM +0200, Mark Kettenis wrote: > > Index: arch/arm/arm/cpu.c > > === > > RCS file: /cvs/src/sys/arch/arm/arm/cpu.c,v >

Re: Some arm cleanups suggested by clang

2016-09-23 Thread Jonathan Gray
On Fri, Sep 23, 2016 at 01:43:04PM +0200, Mark Kettenis wrote: > Most of these are warnings about static symbols that aren't used. The > pmap_get_pde_pte() bit fixes: > > ../../../../arch/arm/arm/pmap7.c:2220:10: warning: comparison of array > 'pm->pm_l2' equal to a null pointer is always

Some arm cleanups suggested by clang

2016-09-23 Thread Mark Kettenis
Most of these are warnings about static symbols that aren't used. The pmap_get_pde_pte() bit fixes: ../../../../arch/arm/arm/pmap7.c:2220:10: warning: comparison of array 'pm->pm_l2' equal to a null pointer is always false [-Wtautological-pointer-compare] if (pm->pm_l2 ==