Re: Superflouous memcpy() in vmctl/main.c

2021-04-02 Thread Dave Voutila
Preben Guldberg writes: > Looking through the code for vmctl, I came across a repeated memcpy() in > vmctl/main.c. > > In the checks below, ret is either set by a memcpy() or defaulted to 0. > > If set by memcpy(), and ret != 0, the memcpy() is repeated verbatim, > which seems unnecessary. > C

Superflouous memcpy() in vmctl/main.c

2021-03-25 Thread Preben Guldberg
Looking through the code for vmctl, I came across a repeated memcpy() in vmctl/main.c. In the checks below, ret is either set by a memcpy() or defaulted to 0. If set by memcpy(), and ret != 0, the memcpy() is repeated verbatim, which seems unnecessary. diff 09b708f572d76de8db7f7948ea7359b19bbd1