Re: Teach pcidump(8) about another capability

2011-01-12 Thread Mark Kettenis
> Date: Thu, 13 Jan 2011 03:10:58 +1100 > From: Jonathan Gray > > ok, but you should add 0x13 "Advanced Features" as well: > > http://www.pcisig.com/specifications/conventional/pci_30/ECN_Conventional_Adv_Caps_27Jul06.pdf Never seen that one. What a horrible name. Feel free to add it if you t

Re: Teach pcidump(8) about another capability

2011-01-12 Thread Jonathan Gray
ok, but you should add 0x13 "Advanced Features" as well: http://www.pcisig.com/specifications/conventional/pci_30/ECN_Conventional_Adv_Caps_27Jul06.pdf On Tue, Jan 11, 2011 at 11:44:54PM +0100, Mark Kettenis wrote: > Capability 0x12 is called "SATA". I have a diff to add PCI_CAP_SATA > to pcireg

Re: Teach pcidump(8) about another capability

2011-01-12 Thread David Gwynne
ok On 12/01/2011, at 8:44 AM, Mark Kettenis wrote: > Capability 0x12 is called "SATA". I have a diff to add PCI_CAP_SATA > to pcireg.h, but given the fact that we're in ABI lock, that'll have > to wait. But it is anyhow better to use the number of elements in the > array to decide whether we "k

Re: Teach pcidump(8) about another capability

2011-01-11 Thread Kenneth R Westerback
On Tue, Jan 11, 2011 at 11:44:54PM +0100, Mark Kettenis wrote: > Capability 0x12 is called "SATA". I have a diff to add PCI_CAP_SATA > to pcireg.h, but given the fact that we're in ABI lock, that'll have > to wait. But it is anyhow better to use the number of elements in the > array to decide whe

Teach pcidump(8) about another capability

2011-01-11 Thread Mark Kettenis
Capability 0x12 is called "SATA". I have a diff to add PCI_CAP_SATA to pcireg.h, but given the fact that we're in ABI lock, that'll have to wait. But it is anyhow better to use the number of elements in the array to decide whether we "know" about a capability or not. ok? Index: pcidump.c ==