Re: acpiec: handle burst mode failure

2016-08-13 Thread Mark Kettenis
> Date: Fri, 12 Aug 2016 08:58:19 -0500 > From: joshua stein > > On Fri, 08 Jul 2016 at 18:51:17 -0500, joshua stein wrote: > > If the EC fails to go into burst mode for whatever reason, the Burst > > Acknowledge byte will not be there to read, which means the status > > won't have EC_STAT_OBF, w

Re: acpiec: handle burst mode failure

2016-08-12 Thread joshua stein
On Fri, 08 Jul 2016 at 18:51:17 -0500, joshua stein wrote: > If the EC fails to go into burst mode for whatever reason, the Burst > Acknowledge byte will not be there to read, which means the status > won't have EC_STAT_OBF, which means acpiec_wait will spin forever, > hanging the machine. > > Thi

Re: acpiec: handle burst mode failure

2016-07-14 Thread Mark Kettenis
> Date: Thu, 14 Jul 2016 16:41:10 -0500 > From: joshua stein > > On Thu, 14 Jul 2016 at 16:31:32 -0500, joshua stein wrote: > > Also, I just checked FreeBSD and they appear to do something similar > > to my patch, where they check that the EC burst mode flag is set in > > the status after trying

Re: acpiec: handle burst mode failure

2016-07-14 Thread joshua stein
On Thu, 14 Jul 2016 at 16:31:32 -0500, joshua stein wrote: > Also, I just checked FreeBSD and they appear to do something similar > to my patch, where they check that the EC burst mode flag is set in > the status after trying to enable it: > > https://github.com/freebsd/freebsd/blob/master/sys/dev

Re: acpiec: handle burst mode failure

2016-07-14 Thread joshua stein
On Sat, 09 Jul 2016 at 16:32:15 -0700, Philip Guenther wrote: > No newer bios for this thing? :-( It is actually the open-source Chrome EC found on the Chromebook Pixel (among others), and according to the source code for the version on this machine, it did not implement burst mode in its ACPI in

Re: acpiec: handle burst mode failure

2016-07-09 Thread Philip Guenther
On Sat, Jul 9, 2016 at 6:08 AM, joshua stein wrote: > On Fri, 08 Jul 2016 at 22:34:34 -0700, Philip Guenther wrote: >> On Fri, Jul 8, 2016 at 4:51 PM, joshua stein wrote: >> > If the EC fails to go into burst mode for whatever reason, the Burst >> > Acknowledge byte will not be there to read, whi

Re: acpiec: handle burst mode failure

2016-07-09 Thread joshua stein
On Fri, 08 Jul 2016 at 22:34:34 -0700, Philip Guenther wrote: > On Fri, Jul 8, 2016 at 4:51 PM, joshua stein wrote: > > If the EC fails to go into burst mode for whatever reason, the Burst > > Acknowledge byte will not be there to read, which means the status > > won't have EC_STAT_OBF, which mean

Re: acpiec: handle burst mode failure

2016-07-08 Thread Philip Guenther
On Fri, Jul 8, 2016 at 4:51 PM, joshua stein wrote: > If the EC fails to go into burst mode for whatever reason, the Burst > Acknowledge byte will not be there to read, which means the status > won't have EC_STAT_OBF, which means acpiec_wait will spin forever, > hanging the machine. > > This at le

acpiec: handle burst mode failure

2016-07-08 Thread joshua stein
If the EC fails to go into burst mode for whatever reason, the Burst Acknowledge byte will not be there to read, which means the status won't have EC_STAT_OBF, which means acpiec_wait will spin forever, hanging the machine. This at least gets us moving again, ignoring the failure to enter burst mo