acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-05 Thread joshua stein
Here we go again... On at least the ThinkPad X1C6, the screen brightness keys (F5 and F6) do not work and "wsconsctl keyboard.backlight" doesn't report the correct value when the keyboard backlight is adjusted with Fn+Space. These are both caused by the default event mask not including these

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-05 Thread James Turner
On Tue, Mar 05, 2019 at 02:03:13PM -0600, joshua stein wrote: > Here we go again... > > On at least the ThinkPad X1C6, the screen brightness keys (F5 and > F6) do not work and "wsconsctl keyboard.backlight" doesn't report > the correct value when the keyboard backlight is adjusted with > Fn+Spa

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-05 Thread Sebastian Benoit
joshua stein(j...@openbsd.org) on 2019.03.05 14:03:13 -0600: > Here we go again... > > On at least the ThinkPad X1C6, the screen brightness keys (F5 and > F6) do not work and "wsconsctl keyboard.backlight" doesn't report > the correct value when the keyboard backlight is adjusted with > Fn+Spac

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-05 Thread Tracey Emery
On Tue, Mar 05, 2019 at 02:03:13PM -0600, joshua stein wrote: > Here we go again... > > On at least the ThinkPad X1C6, the screen brightness keys (F5 and > F6) do not work and "wsconsctl keyboard.backlight" doesn't report > the correct value when the keyboard backlight is adjusted with > Fn+Spa

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-05 Thread Renato Aguiar
Hi Joshua, I just tried your patch on T470p and X230. On T470p, display brightness keys are now working and keyboard backlight is reported correctly by wsconsctl. On X230, display brightness keys are still working fine. Regards, On Tue, Mar 05 2019, joshua stein wrote: Here we go again...

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-06 Thread Claudio Jeker
On Tue, Mar 05, 2019 at 02:03:13PM -0600, joshua stein wrote: > Here we go again... > > On at least the ThinkPad X1C6, the screen brightness keys (F5 and > F6) do not work and "wsconsctl keyboard.backlight" doesn't report > the correct value when the keyboard backlight is adjusted with > Fn+Spa

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-06 Thread Stefan Sperling
On Tue, Mar 05, 2019 at 02:03:13PM -0600, joshua stein wrote: > 0. "newer machines" being those with MHKV reporting version 2. If > this diff breaks on older "newer machines", this metric will have to > be changed to something else. Works fine here on x201 and x250.

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-06 Thread Juan Francisco Cantero Hurtado
On Tue, Mar 05, 2019 at 02:03:13PM -0600, joshua stein wrote: > Here we go again... > > On at least the ThinkPad X1C6, the screen brightness keys (F5 and > F6) do not work and "wsconsctl keyboard.backlight" doesn't report > the correct value when the keyboard backlight is adjusted with > Fn+Spa

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-11 Thread Edd Barrett
On Wed, Mar 06, 2019 at 09:37:52PM +0100, Juan Francisco Cantero Hurtado wrote: > The brightness keys on the X61s still work fine. I've just built today's kernel on my X1 5th gen, and the backlight keys now function. Many thanks jcs@! -- Best Regards Edd Barrett http://www.theunixzoo.co.uk

Re: acpithinkpad: fix brightness keys, keyboard backlight value

2019-03-11 Thread Abel Abraham Camarillo Ojeda
On Mon, Mar 11, 2019 at 4:33 AM Edd Barrett wrote: > On Wed, Mar 06, 2019 at 09:37:52PM +0100, Juan Francisco Cantero Hurtado > wrote: > > The brightness keys on the X61s still work fine. > > I've just built today's kernel on my X1 5th gen, and the backlight keys > now function. > > Many thanks j