Re: cpu utilisation bars for top(1)

2020-04-14 Thread Edd Barrett
Hi, On Mon, Apr 13, 2020 at 07:18:34PM +0100, Stuart Henderson wrote: > It would make better use of the screen space if it worked like systat vm - > multiple characters | (interrupt), @ (spin), = (sys), > (user) ... this fits > a lot more information into the same space than just using a single

Re: cpu utilisation bars for top(1)

2020-04-13 Thread Leo Unglaub
Hey, thanks for the diff. I gave it a try and i really like it. On a server with 32 cores this can be usefull to get a quick look at what is going on. As long as this is not the default and just a toggle it is very usefull for my usecase. Your diff works well on my system. Thanks and

Re: cpu utilisation bars for top(1)

2020-04-13 Thread Stuart Henderson
On 2020/04/13 18:27, Edd Barrett wrote: > On Mon, Apr 13, 2020 at 11:12:46AM -0600, Theo de Raadt wrote: > > > If this is going to be done, it should look the same. I'm not talking > > about the markers above it, but about your arbitrary use of #. > > So you mean the first proposal is good,

Re: cpu utilisation bars for top(1)

2020-04-13 Thread Theo de Raadt
Edd Barrett wrote: > On Mon, Apr 13, 2020 at 11:40:21AM -0600, Theo de Raadt wrote: > > I don't like it. > > > > CPU00 states: 0.0% user, 0.0% nice, 0.0% sys, 0.0% spin, 18.2% intr, > > 81.8% idle > > CPU01 states: 0.0% user, 0.0% nice, 0.0% sys, 0.0% spin, 0.0% intr, > > 100% idle

Re: cpu utilisation bars for top(1)

2020-04-13 Thread Edd Barrett
On Mon, Apr 13, 2020 at 11:40:21AM -0600, Theo de Raadt wrote: > I don't like it. > > CPU00 states: 0.0% user, 0.0% nice, 0.0% sys, 0.0% spin, 18.2% intr, > 81.8% idle > CPU01 states: 0.0% user, 0.0% nice, 0.0% sys, 0.0% spin, 0.0% intr, > 100% idle > > versus > >

Re: cpu utilisation bars for top(1)

2020-04-13 Thread Theo de Raadt
Edd Barrett wrote: > On Mon, Apr 13, 2020 at 11:12:46AM -0600, Theo de Raadt wrote: > > > If this is going to be done, it should look the same. I'm not talking > > about the markers above it, but about your arbitrary use of #. > > So you mean the first proposal is good, just change # to >? I

Re: cpu utilisation bars for top(1)

2020-04-13 Thread Edd Barrett
On Mon, Apr 13, 2020 at 11:15:59AM -0600, Theo de Raadt wrote: > I think your bar-graph removes detailed information and replaces it > with a visual which wastes screen real-estate. I agree, that's why I made it a toggle. -- Best Regards Edd Barrett http://www.theunixzoo.co.uk

Re: cpu utilisation bars for top(1)

2020-04-13 Thread Edd Barrett
On Mon, Apr 13, 2020 at 11:12:46AM -0600, Theo de Raadt wrote: > If this is going to be done, it should look the same. I'm not talking > about the markers above it, but about your arbitrary use of #. So you mean the first proposal is good, just change # to >? Note that systat(1) uses both

Re: cpu utilisation bars for top(1)

2020-04-13 Thread Theo de Raadt
Theo de Raadt wrote: > Edd Barrett wrote: > > > On Mon, Apr 13, 2020 at 06:26:53PM +0200, Sebastian Benoit wrote: > > > If you make them look like the display in systat, you still get the user, > > > ... nice, sys information. Also i like my bikeshed green. > > > > So looking at the bar in

Re: cpu utilisation bars for top(1)

2020-04-13 Thread Theo de Raadt
Edd Barrett wrote: > On Mon, Apr 13, 2020 at 06:26:53PM +0200, Sebastian Benoit wrote: > > If you make them look like the display in systat, you still get the user, > > ... nice, sys information. Also i like my bikeshed green. > > So looking at the bar in `systat vmstat`, we have: > ``` >

Re: cpu utilisation bars for top(1)

2020-04-13 Thread Edd Barrett
On Mon, Apr 13, 2020 at 06:26:53PM +0200, Sebastian Benoit wrote: > If you make them look like the display in systat, you still get the user, > ... nice, sys information. Also i like my bikeshed green. So looking at the bar in `systat vmstat`, we have: ``` 0.0%Int 0.0%Spn 0.1%Sys 25.5%Usr

Re: cpu utilisation bars for top(1)

2020-04-13 Thread Theo de Raadt
Sebastian Benoit wrote: > Edd Barrett(e...@theunixzoo.co.uk) on 2020.04.13 15:47:03 +0100: > > Hi, > > > > One thing I miss from our top(1) is the ability to see overall CPU > > utilisation at a glance (I usually scan for the idle percentage and > > invert it in my head). > > > > This diff

Re: cpu utilisation bars for top(1)

2020-04-13 Thread Sebastian Benoit
Edd Barrett(e...@theunixzoo.co.uk) on 2020.04.13 15:47:03 +0100: > Hi, > > One thing I miss from our top(1) is the ability to see overall CPU > utilisation at a glance (I usually scan for the idle percentage and > invert it in my head). > > This diff adds a way to toggle (using `B`) CPU

cpu utilisation bars for top(1)

2020-04-13 Thread Edd Barrett
Hi, One thing I miss from our top(1) is the ability to see overall CPU utilisation at a glance (I usually scan for the idle percentage and invert it in my head). This diff adds a way to toggle (using `B`) CPU utilisation bars, like this: ``` load averages: 0.92, 0.52, 1.26