doas doesn't need any other open files and should probably shut them all.
Index: doas.c
===
RCS file: /cvs/src/usr.bin/doas/doas.c,v
retrieving revision 1.41
diff -u -p -r1.41 doas.c
--- doas.c 3 Sep 2015 20:05:58 - 1.
ok, but in other places we have closefrom(STDERR_FILENO + 1)
Ted Unangst(t...@tedunangst.com) on 2015.09.17 12:11:26 -0400:
> doas doesn't need any other open files and should probably shut them all.
>
>
> Index: doas.c
> ===
> RCS
Sebastian Benoit wrote:
> ok, but in other places we have closefrom(STDERR_FILENO + 1)
is that really more clear? it only makes sense if you know stderr is 2.
if you sometimes forget which is 1 and which is 2, then the macro only makes
it more confusing because now you have to decide what comes a
Ted Unangst(t...@tedunangst.com) on 2015.09.17 21:12:28 -0400:
> Sebastian Benoit wrote:
> > ok, but in other places we have closefrom(STDERR_FILENO + 1)
>
> is that really more clear? it only makes sense if you know stderr is 2.
sure, but writing closefrom(3) requires the same or equivalent know
On 18/09/15(Fri) 12:02, Sebastian Benoit wrote:
> Ted Unangst(t...@tedunangst.com) on 2015.09.17 21:12:28 -0400:
> > Sebastian Benoit wrote:
> > > ok, but in other places we have closefrom(STDERR_FILENO + 1)
> >
> > is that really more clear? it only makes sense if you know stderr is 2.
What's po