Re: [External] : factor out ipv4 and ipv6 initial packet sanity checks for bridges

2021-05-31 Thread Alexandr Nedvedicky
Hello, On Mon, May 31, 2021 at 02:33:00PM +1000, David Gwynne wrote: > if you're looking at an ip header, it makes sense to do some checks to > make sure that the values and addresses make some sense. the canonical > versions of these checks are in the ipv4 and ipv6 input paths, which > makes

Re: factor out ipv4 and ipv6 initial packet sanity checks for bridges

2021-05-31 Thread Alexander Bluhm
On Mon, May 31, 2021 at 02:33:00PM +1000, David Gwynne wrote: > this is mostly shuffling the deck chairs, but ipv6 is moved around a bit > more than ipv4, so some eyes and tests would be appreciated. Deck shuffling looks correct. OK bluhm@ > +int > +ip6_input_if(struct mbuf **mp, int *offp, int

factor out ipv4 and ipv6 initial packet sanity checks for bridges

2021-05-30 Thread David Gwynne
if you're looking at an ip header, it makes sense to do some checks to make sure that the values and addresses make some sense. the canonical versions of these checks are in the ipv4 and ipv6 input paths, which makes sense. when bridge(4) is about to run packets through pf it makes sure the ip