Re: fix a seg and minor improvements to config(8)

2011-10-02 Thread Nicholas Marriott
don't see any harm in this, ok nicm On Sun, Oct 02, 2011 at 03:44:52PM +0100, Edd Barrett wrote: > On Sat, Oct 01, 2011 at 11:10:35PM -0300, Christiano F. Haesbaert wrote: > > > > Makes sense to me, ok. > > > > Later we should fix the include orderning and change the warning > > printfs to stde

Re: fix a seg and minor improvements to config(8)

2011-10-02 Thread Edd Barrett
On Sat, Oct 01, 2011 at 11:10:35PM -0300, Christiano F. Haesbaert wrote: > > Makes sense to me, ok. > > Later we should fix the include orderning and change the warning > printfs to stderr. Yes. Well, here is the first phase. * As haesbaert suggests, correctly order include files. * Found so

Re: fix a seg and minor improvements to config(8)

2011-10-02 Thread Nicholas Marriott
fine, ok nicm On Sun, Oct 02, 2011 at 10:46:52AM +0100, Edd Barrett wrote: > On Sun, Oct 02, 2011 at 07:22:07AM +0100, Nicholas Marriott wrote: > > Hi > > > > All but the stat bit looks fine. How do you reproduce the problems? It > > seems to fail just fine without it. > > > > $ config -f /x >

Re: fix a seg and minor improvements to config(8)

2011-10-02 Thread Edd Barrett
On Sun, Oct 02, 2011 at 07:22:07AM +0100, Nicholas Marriott wrote: > Hi > > All but the stat bit looks fine. How do you reproduce the problems? It > seems to fail just fine without it. > > $ config -f /x > config: cannot read /x: No such file or directory To reproduce these, you would use -e. I

Re: fix a seg and minor improvements to config(8)

2011-10-01 Thread Nicholas Marriott
Hi All but the stat bit looks fine. How do you reproduce the problems? It seems to fail just fine without it. $ config -f /x config: cannot read /x: No such file or directory Also maybe use access(2) instead? On Wed, Sep 28, 2011 at 02:37:34AM +0100, Edd Barrett wrote: > Evening, > > When usi

Re: fix a seg and minor improvements to config(8)

2011-10-01 Thread Christiano F. Haesbaert
Makes sense to me, ok. Later we should fix the include orderning and change the warning printfs to stderr. Can we get another ok ? On Wed, Sep 28, 2011 at 02:37:34AM +0100, Edd Barrett wrote: > Evening, > > When using `config -e`: > * Don't print a NULL pointer if binary loaded is not a kerne

fix a seg and minor improvements to config(8)

2011-09-27 Thread Edd Barrett
Evening, When using `config -e`: * Don't print a NULL pointer if binary loaded is not a kernel. * Don't segfault of binary loaded is not a kernel. * Report non-existent kernel via a preliminary stat(). * Make a warning look like the rest. OK? Index: exec.c ==