Re: ftp: leak in progressmeter()

2017-09-04 Thread Alexander Bluhm
On Sun, Sep 03, 2017 at 03:19:15PM -0500, Scott Cheloha wrote: > Feedback? It looks like progressmeter() can be called with flag -1 consecutively due to some error path. So better free the title. It cannot hurt. OK bluhm@ > Index: usr.bin/ftp/util.c > ==

ftp: leak in progressmeter()

2017-09-03 Thread Scott Cheloha
Hi, In ftp(1), when displaying the progress meter while not running in verbose mode, if a transfer is aborted and a subsequent transfer is started, we leak title. Given that we only ever print the first 25 bytes of the remote file name we can definitely display the title without going to strdup(3