Date: Fri, 28 Sep 2012 09:31:34 +0200
From: Christiano F. Haesbaert haesba...@openbsd.org
On Fri, Sep 28, 2012 at 02:42:18AM -0400, Brad Smith wrote:
On Wed, Sep 26, 2012 at 03:32:37PM -0400, Brad Smith wrote:
Simplify the gem(4) variant detection code a bit.
OK?
How about
I prefer a switch too, it shows you acknowledged those variants, anyhow i
think the current idiom is bad and should be changed.
On Wed, Sep 26, 2012 at 03:32:37PM -0400, Brad Smith wrote:
Simplify the gem(4) variant detection code a bit.
OK?
How about this..
Index: if_gem_pci.c
===
RCS file: /home/cvs/src/sys/dev/pci/if_gem_pci.c,v
retrieving revision
On Fri, Sep 28, 2012 at 02:42:18AM -0400, Brad Smith wrote:
On Wed, Sep 26, 2012 at 03:32:37PM -0400, Brad Smith wrote:
Simplify the gem(4) variant detection code a bit.
OK?
How about this..
Index: if_gem_pci.c
===
On Fri, Sep 28, 2012 at 09:31:34AM +0200, Christiano F. Haesbaert wrote:
On Fri, Sep 28, 2012 at 02:42:18AM -0400, Brad Smith wrote:
On Wed, Sep 26, 2012 at 03:32:37PM -0400, Brad Smith wrote:
Simplify the gem(4) variant detection code a bit.
OK?
How about this..
Index:
On 2012/09/28 10:08, Kenneth R Westerback wrote:
This is better IMHO. I was mildly concerned about the previous versions that
seemed to recognize previously unknown chips. ok krw@
The driver won't attach to unknown chips anyway, if someone adds a new id
to gem_pci_devices[], either the
Date: Wed, 26 Sep 2012 15:32:37 -0400
From: Brad Smith b...@comstyle.com
Simplify the gem(4) variant detection code a bit.
I don't see the benefit and prefer to keep the code as it is now.
Index: if_gem_pci.c
===
RCS file:
On Wed, Sep 26, 2012 at 15:32, Brad Smith wrote:
Simplify the gem(4) variant detection code a bit.
OK?
Wouldn't a switch be a nicer simplification?
Index: if_gem_pci.c
===
RCS file:
Simplify the gem(4) variant detection code a bit.
OK?
Index: if_gem_pci.c
===
RCS file: /home/cvs/src/sys/dev/pci/if_gem_pci.c,v
retrieving revision 1.31
diff -u -p -r1.31 if_gem_pci.c
--- if_gem_pci.c15 Oct 2009 17:54:56
