Re: iked: merge host_v{4,6}() into host_ip(), simplify host()

2019-11-28 Thread Klemens Nanni
On Thu, Nov 28, 2019 at 09:53:20AM +0100, Tobias Heider wrote: > > voidcopy_satoipa(struct ipsec_addr_wrap *, > > One minor nit: sa in iked usually refers to IPsec security associations, > maybe it would make sense to use "saddr" here? Good point, I'll rename it. > > More

Re: iked: merge host_v{4,6}() into host_ip(), simplify host()

2019-11-28 Thread Tobias Heider
> void copy_satoipa(struct ipsec_addr_wrap *, One minor nit: sa in iked usually refers to IPsec security associations, maybe it would make sense to use "saddr" here? > More tests appreciated. > Feedback? OK? Works for me. ok tobhe@, with or without name change.

Re: iked: merge host_v{4,6}() into host_ip(), simplify host()

2019-11-26 Thread Klemens Nanni
On Wed, Nov 27, 2019 at 05:07:36AM +0100, Klemens Nanni wrote: > As I've already done with pfctl and bgpd, this is the first diff to > convert iked to a more AF agnostic address parsing. > > This diff introduces the copy_satoipa() wrapper and makes set_ipmask() > handle the -1 mask case which will