Re: initial 802.11n implementation

2015-12-12 Thread Stefan Sperling
On Sat, Dec 12, 2015 at 11:56:47AM +0100, Martin Pieuchot wrote: > On 12/12/15(Sat) 00:19, Stefan Sperling wrote: > > Index: net80211/ieee80211_input.c > > === > > RCS file: /cvs/src/sys/net80211/ieee80211_input.c,v > > retrieving revi

Re: initial 802.11n implementation

2015-12-12 Thread Martin Pieuchot
On 12/12/15(Sat) 00:19, Stefan Sperling wrote: > On Sat, Dec 12, 2015 at 12:09:17AM +0100, Stefan Sperling wrote: > > Here's an updated diff, which applies to -current, for testing. > > I'll spend some time tomorrow splitting this up into smaller > > chunks for review with explanations of the chang

Re: initial 802.11n implementation

2015-12-11 Thread Stefan Sperling
On Sat, Dec 12, 2015 at 12:09:17AM +0100, Stefan Sperling wrote: > Here's an updated diff, which applies to -current, for testing. > I'll spend some time tomorrow splitting this up into smaller > chunks for review with explanations of the changes. > > No known problems exist with this diff. > Plea

Re: initial 802.11n implementation

2015-12-11 Thread Stefan Sperling
Here's an updated diff, which applies to -current, for testing. I'll spend some time tomorrow splitting this up into smaller chunks for review with explanations of the changes. No known problems exist with this diff. Please test anywhere, even without iwm(4). Thanks. Index: dev/pci/if_iwm.c =

Re: initial 802.11n implementation

2015-11-16 Thread Stefan Sperling
On Mon, Nov 16, 2015 at 11:56:27AM +0100, Martin Pieuchot wrote: > I'm not saying that's better. I'm saying that the actual 11n driver/ > stack glue has been designed with iwn(4)'s behavior in mind. So I > think that's one argument more to do the same with iwm(4)... At least > at this stage. Bu

Re: initial 802.11n implementation

2015-11-16 Thread Martin Pieuchot
On 15/11/15(Sun) 21:32, Stefan Sperling wrote: > On Sun, Nov 15, 2015 at 08:27:28PM +0100, Martin Pieuchot wrote: > > I'm really concerned about the use of tasks in iwm_ampdu_rx_{start,stop} > > > > By looking at iwn(4) which also has a lot of bits for handling A-MPDU > > and A-MSDU frames, it see

Re: initial 802.11n implementation

2015-11-15 Thread Stefan Sperling
On Sun, Nov 15, 2015 at 08:27:28PM +0100, Martin Pieuchot wrote: > I'm really concerned about the use of tasks in iwm_ampdu_rx_{start,stop} > > By looking at iwn(4) which also has a lot of bits for handling A-MPDU > and A-MSDU frames, it seems to me that this go against damien@'s design. > This de

Re: initial 802.11n implementation

2015-11-15 Thread Martin Pieuchot
On 15/11/15(Sun) 14:34, Stefan Sperling wrote: > On Thu, Nov 12, 2015 at 08:22:07PM +0100, Stefan Sperling wrote: > > This diff adds an initial implementation of 802.11n. > > Some of this has now been committed. > > The diff below shows the outstanding parts relative to -current. > > - receivin

Re: initial 802.11n implementation

2015-11-15 Thread Stefan Sperling
On Thu, Nov 12, 2015 at 08:22:07PM +0100, Stefan Sperling wrote: > This diff adds an initial implementation of 802.11n. Some of this has now been committed. The diff below shows the outstanding parts relative to -current. - receiving A-MPDU and A-MSDU frames - 11n support for the iwm(4) driver

Re: initial 802.11n implementation

2015-11-13 Thread Martin Pieuchot
On 12/11/15(Thu) 20:22, Stefan Sperling wrote: > This diff adds an initial implementation of 802.11n. > > [...] Looks good. I think you should already put in the chunks below. Especially the one needed for ifconfig(8). I think I found a typo... > Index: net/if_media.h > ===

Re: initial 802.11n implementation

2015-11-13 Thread Stefan Sperling
On Thu, Nov 12, 2015 at 08:22:07PM +0100, Stefan Sperling wrote: > This diff adds an initial implementation of 802.11n. While testing this diff, please pay attention to stuttering behaviour in audio before and after applying this diff. If you're hearing audio stutter as a side effect of this diff,

initial 802.11n implementation

2015-11-12 Thread Stefan Sperling
This diff adds an initial implementation of 802.11n. It is functional but mostly adds foundations to build future work on top of. It completes the little bits of 11n code added by damien@ years ago. It supports all non-optional 11n features for STA (client) operation. It adds 11n support only for