Re: klog message buffer full

2016-06-22 Thread Theo de Raadt
> But if install kernel size is not that important, I can remove both > ifdefs. Kernel size does matter on the ramdisks. But excessive sprinkling of #ifdef gets out of control in some types of code. Then it better to forego it, and find a different target where it is less gross. As long as we

Re: klog message buffer full

2016-06-22 Thread Alexander Bluhm
On Wed, Jun 22, 2016 at 05:08:24PM -0400, Ted Unangst wrote: > Alexander Bluhm wrote: > > +#ifndef SMALL_KERNEL > > + if (mbp->msg_bufd > 0) { > > + char buf[64]; > > This is not so much code that I'm worried about it on small kernels. Rather, > now you have the same problem where some

Re: klog message buffer full

2016-06-22 Thread Ted Unangst
Alexander Bluhm wrote: > This also gets me closer to my goal of reliable logging. > > Do we want this feature? yes, and I'd say always. > +#ifndef SMALL_KERNEL > + if (mbp->msg_bufd > 0) { > + char buf[64]; This is not so much code that I'm worried about it on small kernels. Rat

Re: klog message buffer full

2016-06-22 Thread Todd C. Miller
On Wed, 22 Jun 2016 22:14:19 +0200, Alexander Bluhm wrote: > When doing usb debugging with a lot of kernel printfs, the dmesg > buffer can overflow easily. It is annoying that you don't notice > this. Then it is hard to correlate the messages. > > So to make clear what happens, I would like to

klog message buffer full

2016-06-22 Thread Alexander Bluhm
Hi, When doing usb debugging with a lot of kernel printfs, the dmesg buffer can overflow easily. It is annoying that you don't notice this. Then it is hard to correlate the messages. So to make clear what happens, I would like to write such a message to syslogd: Jun 22 21:58:16 t430s /bsd: usbd