Re: ktrwriteraw & vget

2020-03-17 Thread Martin Pieuchot
On 17/03/20(Tue) 07:50, Philip Guenther wrote: > On Tue, Mar 17, 2020 at 5:18 AM Martin Pieuchot wrote: > > On 17/03/20(Tue) 04:02, Philip Guenther wrote: > > > On Tue, Mar 17, 2020 at 1:07 AM Martin Pieuchot wrote: > > > [...] > > > > @@ -663,8 +668,6 @@ ktrwriteraw(struct proc *curp, struct vn

Re: ktrwriteraw & vget

2020-03-17 Thread Philip Guenther
On Tue, Mar 17, 2020 at 5:18 AM Martin Pieuchot wrote: > On 17/03/20(Tue) 04:02, Philip Guenther wrote: > > On Tue, Mar 17, 2020 at 1:07 AM Martin Pieuchot wrote: > > [...] > > > @@ -663,8 +668,6 @@ ktrwriteraw(struct proc *curp, struct vn > > > LIST_FOREACH(pr, , ps_list) > > >

Re: ktrwriteraw & vget

2020-03-17 Thread Martin Pieuchot
On 17/03/20(Tue) 04:02, Philip Guenther wrote: > On Tue, Mar 17, 2020 at 1:07 AM Martin Pieuchot wrote: > [...] > > @@ -663,8 +668,6 @@ ktrwriteraw(struct proc *curp, struct vn > > LIST_FOREACH(pr, , ps_list) > > if (pr->ps_tracevp == vp && pr->ps_tracecred == cred) > >

Re: ktrwriteraw & vget

2020-03-17 Thread Philip Guenther
On Tue, Mar 17, 2020 at 1:07 AM Martin Pieuchot wrote: > On 16/03/20(Mon) 14:01, Martin Pieuchot wrote: > > vget(9) might fail, stop right away if that happens. > > > > CID 1453020 Unchecked return value. > > Updated diff that stops tracing if vget(9) fails, similar to what's > currently done if

Re: ktrwriteraw & vget

2020-03-17 Thread Martin Pieuchot
On 16/03/20(Mon) 14:01, Martin Pieuchot wrote: > vget(9) might fail, stop right away if that happens. > > CID 1453020 Unchecked return value. Updated diff that stops tracing if vget(9) fails, similar to what's currently done if VOP_WRITE(9) fails, suggested by visa@. Code shuffling is there to

ktrwriteraw & vget

2020-03-16 Thread Martin Pieuchot
vget(9) might fail, stop right away if that happens. CID 1453020 Unchecked return value. ok? Index: kern//kern_ktrace.c === RCS file: /cvs/src/sys/kern/kern_ktrace.c,v retrieving revision 1.100 diff -u -p -r1.100 kern_ktrace.c ---