Re: ldapd(8): fix, simplify UUID timestamp code

2020-09-03 Thread Robert Klein
Hi, On Fri, 21 Aug 2020 22:34:35 +1000 Jonathan Matthew wrote: > On Wed, Aug 19, 2020 at 09:28:41PM -0500, Scott Cheloha wrote: > > Hi, > > > > I was auditing the tree for odd-looking time structure usage and I > > came across the UUID code in ldapd(8), uuid.c. > > > > time_cmp() is backwards.

Re: ldapd(8): fix, simplify UUID timestamp code

2020-08-21 Thread Jonathan Matthew
On Wed, Aug 19, 2020 at 09:28:41PM -0500, Scott Cheloha wrote: > Hi, > > I was auditing the tree for odd-looking time structure usage and I > came across the UUID code in ldapd(8), uuid.c. > > time_cmp() is backwards. Or the caller is misusing it. One or the > other. It returns -1 if tv1 excee

ldapd(8): fix, simplify UUID timestamp code

2020-08-19 Thread Scott Cheloha
Hi, I was auditing the tree for odd-looking time structure usage and I came across the UUID code in ldapd(8), uuid.c. time_cmp() is backwards. Or the caller is misusing it. One or the other. It returns -1 if tv1 exceeds tv2 but the comments in the caller indicate the opposite impression. I do