Re: less(1) ctype fixes

2015-11-12 Thread Stefan Sperling
On Wed, Nov 11, 2015 at 07:27:35PM -0500, Michael McConville wrote: > is_optchar() could also take an int in order to be more compatible with > the ctype functions. Perhaps for consistency it would be better to pass an int in and cast to unsigned char when handing off to ctype. I've gotten used

less(1) ctype fixes

2015-11-11 Thread Michael McConville
is_optchar() could also take an int in order to be more compatible with the ctype functions. isupper() || islower() is equivalent to isalpha() in the C locale, but not necessarily in others (see the isalpha(3) manpage). We could use stdbool to make is_optchar() a one-liner, but I'll resist the