Re: libedit: stop ignoring SIGINT

2021-08-09 Thread Otto Moerbeek
On Mon, Aug 09, 2021 at 07:20:31AM -0600, Theo de Raadt wrote: > Ingo Schwarze wrote: > > > as mentioned earlier, deraadt@ reported that sftp(1) ignores Ctrl-C. > > Fixing that without longjmp(3) requires making editline(3) better > > behaved. > > If a library interface encourages use

Re: libedit: stop ignoring SIGINT

2021-08-09 Thread Martijn van Duren
On Mon, 2021-08-09 at 15:17 +0200, Ingo Schwarze wrote: > Hi Martijn, > > Martijn van Duren wrote on Mon, Aug 09, 2021 at 02:15:42PM +0200: > > > If we're stripping down fixio to a single function, why not > > inline the whole thing? > > I deliberately tried to: > >  1. Keep patches that

Re: libedit: stop ignoring SIGINT

2021-08-09 Thread Theo de Raadt
Ingo Schwarze wrote: > > So if we decide which of our interpretations should take precedence > > it might be a good idea to put it into snaps for a while. > > I don't think so in this case. Let's not over-use the feature of > putting stuff in snaps. I think that should be reserved for stuff >

Re: libedit: stop ignoring SIGINT

2021-08-09 Thread Theo de Raadt
Ingo Schwarze wrote: > as mentioned earlier, deraadt@ reported that sftp(1) ignores Ctrl-C. > Fixing that without longjmp(3) requires making editline(3) better > behaved. If a library interface encourages use longjmp(), that library should be thrown into the dustbin of history. Our src tree

Re: libedit: stop ignoring SIGINT

2021-08-09 Thread Ingo Schwarze
Hi Martijn, Martijn van Duren wrote on Mon, Aug 09, 2021 at 02:15:42PM +0200: > If we're stripping down fixio to a single function, why not > inline the whole thing? I deliberately tried to: 1. Keep patches that change behaviour as small as possible to make review as simple as possible

Re: libedit: stop ignoring SIGINT

2021-08-09 Thread Claudio Jeker
On Mon, Aug 09, 2021 at 01:19:08PM +0200, Ingo Schwarze wrote: > Hi, > > as mentioned earlier, deraadt@ reported that sftp(1) ignores Ctrl-C. > Fixing that without longjmp(3) requires making editline(3) better > behaved. > > Currently, when read(2) from the terminal gets interrupted by a >

Re: libedit: stop ignoring SIGINT

2021-08-09 Thread Martijn van Duren
On Mon, 2021-08-09 at 14:15 +0200, Martijn van Duren wrote: > On Mon, 2021-08-09 at 13:19 +0200, Ingo Schwarze wrote: > > Hi, > > > > as mentioned earlier, deraadt@ reported that sftp(1) ignores Ctrl-C. > > Fixing that without longjmp(3) requires making editline(3) better > > behaved. > > > >

Re: libedit: stop ignoring SIGINT

2021-08-09 Thread Martijn van Duren
On Mon, 2021-08-09 at 13:19 +0200, Ingo Schwarze wrote: > Hi, > > as mentioned earlier, deraadt@ reported that sftp(1) ignores Ctrl-C. > Fixing that without longjmp(3) requires making editline(3) better > behaved. > > Currently, when read(2) from the terminal gets interrupted by a > signal,

libedit: stop ignoring SIGINT

2021-08-09 Thread Ingo Schwarze
Hi, as mentioned earlier, deraadt@ reported that sftp(1) ignores Ctrl-C. Fixing that without longjmp(3) requires making editline(3) better behaved. Currently, when read(2) from the terminal gets interrupted by a signal, editline(3) ignores the (first) signal and unconditionally calls read(2) a