On Thu, 23 Aug 2018 11:24:54 -0500, Scott Cheloha wrote:
> On Tue, Aug 14, 2018 at 03:11:47PM -0500, Scott Cheloha wrote:
> > This patch is ok cheloha@ and I can commit if someone else
> > is ok, too.
>
> 1 week bump. Anyone else ok?
OK millert@
- todd
On Thu, Aug 23 2018 11:24:54 -0500, Scott Cheloha wrote:
> On Tue, Aug 14, 2018 at 03:11:47PM -0500, Scott Cheloha wrote:
> > This patch is ok cheloha@ and I can commit if someone else
> > is ok, too.
>
> 1 week bump. Anyone else ok?
no takers?
--
Lauri Tirkkonen | lotheac @ IRCnet
On Tue, Aug 14, 2018 at 03:11:47PM -0500, Scott Cheloha wrote:
> This patch is ok cheloha@ and I can commit if someone else
> is ok, too.
1 week bump. Anyone else ok?
> On Tue, Aug 14, 2018 at 10:47:07PM +0300, Lauri Tirkkonen wrote:
> > [...]
> >
> > diff --git a/bin/md5/md5.c b/bin/md5/md5.c
This patch is ok cheloha@ and I can commit if someone else
is ok, too.
On Tue, Aug 14, 2018 at 10:47:07PM +0300, Lauri Tirkkonen wrote:
> [...]
>
> diff --git a/bin/md5/md5.c b/bin/md5/md5.c
> index 84adbcf0989..1abf28cfa16 100644
> --- a/bin/md5/md5.c
> +++ b/bin/md5/md5.c
> @@ -549,11 +549,11 @
On Tue, Aug 14 2018 14:29:30 -0500, Scott Cheloha wrote:
> On Tue, Aug 14, 2018 at 08:55:14PM +0300, Lauri Tirkkonen wrote:
> > Hi,
> >
> > On Tue, Aug 14 2018 12:08:54 -0500, Scott Cheloha wrote:
> > > > + len = (size_t)linelen;
> > > > + if (line[len - 1] == '\n')
> >
On Tue, Aug 14, 2018 at 08:55:14PM +0300, Lauri Tirkkonen wrote:
> Hi,
>
> On Tue, Aug 14 2018 12:08:54 -0500, Scott Cheloha wrote:
> > > + len = (size_t)linelen;
> > > + if (line[len - 1] == '\n')
> > > + line[len - 1] = '\0';
> >
> > You can just use linelen dire
Hi,
On Tue, Aug 14 2018 12:08:54 -0500, Scott Cheloha wrote:
> > + len = (size_t)linelen;
> > + if (line[len - 1] == '\n')
> > + line[len - 1] = '\0';
>
> You can just use linelen directly and skip the assignment.
I did it this way because this bit later
On Tue, Aug 14, 2018 at 03:34:53PM +0300, Lauri Tirkkonen wrote:
> Similar to previous diffs for join(1) and paste(1). No intended
> functional change.
I agree with the direction. Comments inline.
> diff --git a/bin/md5/md5.c b/bin/md5/md5.c
> index 84adbcf0989..a8f18262a92 100644
> --- a/bin/md
Similar to previous diffs for join(1) and paste(1). No intended
functional change.
diff --git a/bin/md5/md5.c b/bin/md5/md5.c
index 84adbcf0989..a8f18262a92 100644
--- a/bin/md5/md5.c
+++ b/bin/md5/md5.c
@@ -549,11 +549,11 @@ digest_filelist(const char *file, struct hash_function
*defhash, int se
