Re: ospfd announces carp interface with physical link down

2015-05-21 Thread Martin Pieuchot
On 20/05/15(Wed) 14:14, Johan Ymerson wrote: > [...] > The patch did not apply cleanly to OPENBSD_5_7, I rewrote the patch a > bit: Thanks, I committed my diff to -current. > With this patch everything (almost) work. At least as good as my patch > did. OSPFd still does something wrong with the li

Re: ospfd announces carp interface with physical link down

2015-05-20 Thread Johan Ymerson
On Wed, 20 May 2015 12:51:53 +0200 Martin Pieuchot wrote: > > > just for completeness: LINK_STATE_INVALID is 1, and that's what > > carp_set_state uses for everything but master and backup. so far so > > good. > > > > ifp is part of the sc which in turn is malloc'd with M_ZERO in > > carp_clon

Re: ospfd announces carp interface with physical link down

2015-05-20 Thread Martin Pieuchot
On 20/05/15(Wed) 07:40, Henning Brauer wrote: > * Johan Ymerson [2015-05-19 19:25]: > > On Tue, 2015-05-19 at 11:16 +, Johan Ymerson wrote: > > > On Tue, 2015-05-19 at 11:24 +0100, Stuart Henderson wrote: > > > > On 2015/05/19 10:10, Johan Ymerson wrote: > > > > Yes I understand that, but if c

Re: ospfd announces carp interface with physical link down

2015-05-19 Thread Henning Brauer
* Johan Ymerson [2015-05-19 19:25]: > On Tue, 2015-05-19 at 11:16 +, Johan Ymerson wrote: > > On Tue, 2015-05-19 at 11:24 +0100, Stuart Henderson wrote: > > > On 2015/05/19 10:10, Johan Ymerson wrote: > > > Yes I understand that, but if carp init was counted in "LINK_STATE_DOWN" > > > then the

Re: ospfd announces carp interface with physical link down

2015-05-19 Thread Johan Ymerson
On Tue, 2015-05-19 at 11:16 +, Johan Ymerson wrote: > On Tue, 2015-05-19 at 11:24 +0100, Stuart Henderson wrote: > > On 2015/05/19 10:10, Johan Ymerson wrote: > > > > Yes I understand that, but if carp init was counted in "LINK_STATE_DOWN" > > then the metric would be 65535 which I think would

Re: ospfd announces carp interface with physical link down

2015-05-19 Thread Johan Ymerson
On Tue, 2015-05-19 at 11:24 +0100, Stuart Henderson wrote: > On 2015/05/19 10:10, Johan Ymerson wrote: > > Yes I understand that, but if carp init was counted in "LINK_STATE_DOWN" > then the metric would be 65535 which I think would still avoid the > problem you're seeing, and would involve less s

Re: ospfd announces carp interface with physical link down

2015-05-19 Thread Stuart Henderson
On 2015/05/19 10:10, Johan Ymerson wrote: > On Tue, 2015-05-19 at 10:10 +0100, Stuart Henderson wrote: > > On 2015/05/19 09:03, Johan Ymerson wrote: > > > On Fri, 2015-05-15 at 17:59 +0200, Johan Ymerson wrote: > > > > I have found a peculiar behaviour in ospfd when the physical link of the > > > >

Re: ospfd announces carp interface with physical link down

2015-05-19 Thread Johan Ymerson
On Tue, 2015-05-19 at 10:10 +0100, Stuart Henderson wrote: > On 2015/05/19 09:03, Johan Ymerson wrote: > > On Fri, 2015-05-15 at 17:59 +0200, Johan Ymerson wrote: > > > I have found a peculiar behaviour in ospfd when the physical link of the > > > parent carp interface is down. The carp interface n

Re: ospfd announces carp interface with physical link down

2015-05-19 Thread Stuart Henderson
On 2015/05/19 09:03, Johan Ymerson wrote: > On Fri, 2015-05-15 at 17:59 +0200, Johan Ymerson wrote: > > I have found a peculiar behaviour in ospfd when the physical link of the > > parent carp interface is down. The carp interface net is then announced > > with it's regular metric. > > > > An exam

Re: ospfd announces carp interface with physical link down

2015-05-19 Thread Johan Ymerson
On Fri, 2015-05-15 at 17:59 +0200, Johan Ymerson wrote: > I have found a peculiar behaviour in ospfd when the physical link of the > parent carp interface is down. The carp interface net is then announced > with it's regular metric. > > An example: > The cable of em2, parent of carp2 (192.168.254.

ospfd announces carp interface with physical link down

2015-05-15 Thread Johan Ymerson
I have found a peculiar behaviour in ospfd when the physical link of the parent carp interface is down. The carp interface net is then announced with it's regular metric. An example: The cable of em2, parent of carp2 (192.168.254.0/23), is unplugged. Here is what is announced, seen by another mach