Re: pf: remove pfr_{sin,sin6,mask} globals

2017-05-09 Thread Mike Belopuhov
On Tue, May 09, 2017 at 14:13 +0200, Patrick Wildt wrote: > On Tue, May 09, 2017 at 01:55:18PM +0200, Mike Belopuhov wrote: > > On Tue, May 09, 2017 at 10:36 +0200, Patrick Wildt wrote: > > > On Mon, May 08, 2017 at 02:56:55PM +0200, Patrick Wildt wrote: > > > > @@ -2307,9 +2326,9 @@ pfr_pool_get(s

Re: pf: remove pfr_{sin,sin6,mask} globals

2017-05-09 Thread Mike Belopuhov
On 9 May 2017 at 14:13, Patrick Wildt wrote: > On Tue, May 09, 2017 at 01:55:18PM +0200, Mike Belopuhov wrote: > > On Tue, May 09, 2017 at 10:36 +0200, Patrick Wildt wrote: > > > On Mon, May 08, 2017 at 02:56:55PM +0200, Patrick Wildt wrote: > > > > @@ -2307,9 +2326,9 @@ pfr_pool_get(struct pf_po

Re: pf: remove pfr_{sin,sin6,mask} globals

2017-05-09 Thread Patrick Wildt
On Tue, May 09, 2017 at 01:55:18PM +0200, Mike Belopuhov wrote: > On Tue, May 09, 2017 at 10:36 +0200, Patrick Wildt wrote: > > On Mon, May 08, 2017 at 02:56:55PM +0200, Patrick Wildt wrote: > > > @@ -2307,9 +2326,9 @@ pfr_pool_get(struct pf_pool *rpool, struct pf_addr > > > **raddr, > > >

Re: pf: remove pfr_{sin,sin6,mask} globals

2017-05-09 Thread Mike Belopuhov
On Tue, May 09, 2017 at 10:36 +0200, Patrick Wildt wrote: > On Mon, May 08, 2017 at 02:56:55PM +0200, Patrick Wildt wrote: > > @@ -2307,9 +2326,9 @@ pfr_pool_get(struct pf_pool *rpool, struct pf_addr > > **raddr, > > rpool->curweight = kt->pfrkt_maxweight; > > } > > > > -

Re: pf: remove pfr_{sin,sin6,mask} globals

2017-05-09 Thread Patrick Wildt
On Mon, May 08, 2017 at 02:56:55PM +0200, Patrick Wildt wrote: > @@ -2307,9 +2326,9 @@ pfr_pool_get(struct pf_pool *rpool, struct pf_addr > **raddr, > rpool->curweight = kt->pfrkt_maxweight; > } > > - pfr_prepare_network(&pfr_mask, af, ke->pfrke_net); > + pfr_

Re: pf: remove pfr_{sin,sin6,mask} globals

2017-05-08 Thread Alexandr Nedvedicky
Hello Patrick, your diff looks OK to me. thanks and regards sasha On Mon, May 08, 2017 at 02:56:55PM +0200, Patrick Wildt wrote: > Hi, > > in order to reduce globals so that we can run more parts of pf in > parallel, this diff removes the pfr_sin, pfr_sin6 and pfr_mask > globals. Those are ins

pf: remove pfr_{sin,sin6,mask} globals

2017-05-08 Thread Patrick Wildt
Hi, in order to reduce globals so that we can run more parts of pf in parallel, this diff removes the pfr_sin, pfr_sin6 and pfr_mask globals. Those are instead allocated on the stack. ok? Patrick diff --git a/sys/net/pf_table.c b/sys/net/pf_table.c index 708bd68cbcd..2cdff265ff5 100644 --- a/s