ping6: err() when setsockopts fail

2018-11-10 Thread David Gwynne
this good idea was suggested by kn@ and deraadt@ ok? Index: ping.c === RCS file: /cvs/src/sbin/ping/ping.c,v retrieving revision 1.232 diff -u -p -r1.232 ping.c --- ping.c 10 Nov 2018 23:44:53 - 1.232 +++ ping.c 10

Re: ping6: err() when setsockopts fail

2018-11-10 Thread Alexander Bluhm
On Sun, Nov 11, 2018 at 09:48:09AM +1000, David Gwynne wrote: > this good idea was suggested by kn@ and deraadt@ > > ok? OK bluhm@ I think the cast to socklen_t in (socklen_t)sizeof(optval) is not good. We should just let the compiler make its job. bluhm > Index: ping.c >

Re: ping6: err() when setsockopts fail

2018-11-10 Thread Theo de Raadt
Alexander Bluhm wrote: > I think the cast to socklen_t in (socklen_t)sizeof(optval) is not > good. We should just let the compiler make its job. true, I have a name for those, "potentially truncating casts" of course you need to determine what the types are, but that's the whole point, it is

Re: ping6: err() when setsockopts fail

2018-11-10 Thread Klemens Nanni
On Sat, Nov 10, 2018 at 05:03:42PM -0700, Alexander Bluhm wrote: > On Sun, Nov 11, 2018 at 09:48:09AM +1000, David Gwynne wrote: > > this good idea was suggested by kn@ and deraadt@ > > > > ok? > > OK bluhm@ > > I think the cast to socklen_t in (socklen_t)sizeof(optval) is not > good. We should