Re: pool_debug is good, but also bad

2011-04-04 Thread Mark Kettenis
Date: Sun, 03 Apr 2011 18:38:51 -0600 From: Theo de Raadt dera...@cvs.openbsd.org based on a conversation at the bar. POOL_DEBUG is expensive. But we really want it because it finds bugs before they hurt us. The solution to this is to make it simpler to turn off. This diff starts the

Re: pool_debug is good, but also bad

2011-04-04 Thread Thordur Bjornsson
On Sun, Apr 03, 2011 at 06:38:51PM -0600, Theo de Raadt wrote: based on a conversation at the bar. POOL_DEBUG is expensive. But we really want it because it finds bugs before they hurt us. The solution to this is to make it simpler to turn off. This diff starts the kernel with pool debug

pool_debug is good, but also bad

2011-04-03 Thread Theo de Raadt
based on a conversation at the bar. POOL_DEBUG is expensive. But we really want it because it finds bugs before they hurt us. The solution to this is to make it simpler to turn off. This diff starts the kernel with pool debug on, but allows it to be turned off with sysctl kern.pool_debug=0.

Re: pool_debug is good, but also bad

2011-04-03 Thread Damien Miller
On Sun, 3 Apr 2011, Theo de Raadt wrote: based on a conversation at the bar. POOL_DEBUG is expensive. But we really want it because it finds bugs before they hurt us. The solution to this is to make it simpler to turn off. Is it expensive because it tests every pool entry? Could it be