Re: queue packet in loopback

2017-10-18 Thread Alexandr Nedvedicky
Hello, On Wed, Oct 18, 2017 at 08:13:09PM +0200, Alexander Bluhm wrote: > On Wed, Oct 18, 2017 at 10:48:30AM +0200, Alexandr Nedvedicky wrote: > > I think you also want to add if_ih_remove() to loop_clone_destroy(). > > Yes, thanks for catching that. > > > I feel it should be called afte

Re: queue packet in loopback

2017-10-18 Thread Alexander Bluhm
On Wed, Oct 18, 2017 at 10:48:30AM +0200, Alexandr Nedvedicky wrote: > I think you also want to add if_ih_remove() to loop_clone_destroy(). Yes, thanks for catching that. > I feel it should be called after if_detach(). I disagree. Other pseudo-interfaces call it before. But more import

Re: queue packet in loopback

2017-10-18 Thread Alexandr Nedvedicky
Hello, thanks for great explanation of the problem. I like your approach. I have just two small nitpicks/questions see below. > > Index: net/if_loop.c > === > RCS file: /data/mirror/openbsd/cvs/src/sys/net/if_loop.c,v > retrievin

queue packet in loopback

2017-10-17 Thread Alexander Bluhm
Hi, markus@ has found a possible stack overrun in the network as we have removed some queueing. Now lo(4) output calls the ip input routines without a queue. So if a packet loops through the kernel, the kernel stack fills up. root@q70:.../~# route add 1.2.3.4 127.0.0.1 add host 1.2.3.4: gateway