Re: refactor bgpd up_generate_updates()

2022-03-30 Thread Claudio Jeker
On Wed, Mar 30, 2022 at 03:10:58PM +0200, Theo Buehler wrote: > On Wed, Mar 30, 2022 at 02:38:54PM +0200, Claudio Jeker wrote: > > Change the code to use less goto and instead use a while loop. > > I think the result is easier to understand. > > Yes this is clearer and preserves the current

Re: refactor bgpd up_generate_updates()

2022-03-30 Thread Theo Buehler
On Wed, Mar 30, 2022 at 02:38:54PM +0200, Claudio Jeker wrote: > Change the code to use less goto and instead use a while loop. > I think the result is easier to understand. Yes this is clearer and preserves the current logic, so I'm ok with it. Here's an alternative approach: unless I'm missing

refactor bgpd up_generate_updates()

2022-03-30 Thread Claudio Jeker
Change the code to use less goto and instead use a while loop. I think the result is easier to understand. OK? -- :wq Claudio Index: rde_update.c === RCS file: /cvs/src/usr.sbin/bgpd/rde_update.c,v retrieving revision 1.138 diff -u