Re: remove #ifndef MKNOD from ksh(1) and enforce pledge(2) on all codepaths

2015-12-26 Thread Theo de Raadt
No thanks. I don't want my shell able to intrinsically create nodes. Let's keep it as it is. Or even better keep the #ifndef since mknod(8) already has dpath annotation: Index: main.c === RCS file: /

Re: remove #ifndef MKNOD from ksh(1) and enforce pledge(2) on all codepaths

2015-12-26 Thread Ricardo Mestre
Please disregard this for now, -m (extended permissions) won't work this way Thanks for the tip tb@ On 18:33 Sat 26 Dec , Ricardo Mestre wrote: > Or even better keep the #ifndef since mknod(8) already has dpath annotation: > > Index: main.c > ==

remove #ifndef MKNOD from ksh(1) and enforce pledge(2) on all codepaths

2015-12-26 Thread Ricardo Mestre
Hi tech@ Now that dpath annotation in pledge(2) is available then #ifndef MKNOD can be removed and enforce pledge(2) on all codepaths, is this correct, comments? Index: main.c === RCS file: /cvs/src/bin/ksh/main.c,v retrieving revisi

Re: remove #ifndef MKNOD from ksh(1) and enforce pledge(2) on all codepaths

2015-12-26 Thread Ricardo Mestre
Or even better keep the #ifndef since mknod(8) already has dpath annotation: Index: main.c === RCS file: /cvs/src/bin/ksh/main.c,v retrieving revision 1.75 diff -u -p -u -r1.75 main.c --- main.c 14 Dec 2015 13:59:42 - 1.