Re: ripd: memory leak and double free/use-after-free

2019-12-11 Thread Remi Locherer
On Wed, Dec 11, 2019 at 10:11:58AM +0100, Sebastian Benoit wrote: > Remi Locherer(remi.loche...@relo.ch) on 2019.12.10 22:39:32 +0100: > > On Tue, Dec 10, 2019 at 07:05:27PM +0100, Hiltjo Posthuma wrote: > > > Hi, > > > > > > While looking at the code of ripd: > > > > > > I think there are

Re: ripd: memory leak and double free/use-after-free

2019-12-11 Thread Sebastian Benoit
Remi Locherer(remi.loche...@relo.ch) on 2019.12.10 22:39:32 +0100: > On Tue, Dec 10, 2019 at 07:05:27PM +0100, Hiltjo Posthuma wrote: > > Hi, > > > > While looking at the code of ripd: > > > > I think there are (also) 2 small memleaks in a debug/error path > > (IMSG_REQUEST_ADD and

Re: ripd: memory leak and double free/use-after-free

2019-12-10 Thread Remi Locherer
On Tue, Dec 10, 2019 at 07:05:27PM +0100, Hiltjo Posthuma wrote: > Hi, > > While looking at the code of ripd: > > I think there are (also) 2 small memleaks in a debug/error path > (IMSG_REQUEST_ADD and IMSG_RESPONSE_ADD). It breaks out before adding the > struct rip_route as an entry by the

ripd: memory leak and double free/use-after-free

2019-12-10 Thread Hiltjo Posthuma
Hi, While looking at the code of ripd: I think there are (also) 2 small memleaks in a debug/error path (IMSG_REQUEST_ADD and IMSG_RESPONSE_ADD). It breaks out before adding the struct rip_route as an entry by the add_entry function (which adds it and adds a reference count) in the log_debug